Fix bug in fixed_problem_computation #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliceb-nv
approved these changes
Sep 19, 2025
Contributor
aliceb-nv
left a comment
aliceb-nv
left a comment
There was a problem hiding this comment.
Approving, great catch - thanks a lot Akif!
rgsl888prabhu
approved these changes
Sep 19, 2025
Contributor
|
/merge |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
The issue was the problem check that some constraint values were going -inf and nan. This was caught by exceptions but it didn't crash the process as it is caught. We need more graceful handling of exceptions: #264 Authors: - Akif ÇÖRDÜK (https://github.com/akifcorduk) Approvers: - Alice Boucher (https://github.com/aliceb-nv) - Ramakrishnap (https://github.com/rgsl888prabhu) URL: #403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was the problem check that some constraint values were going -inf and nan. This was caught by exceptions but it didn't crash the process as it is caught. We need more graceful handling of exceptions: #264