Skip to content

Combine conda install for local and channel based artifacts into one env create call #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 10 commits into from
Oct 1, 2025
Merged

Combine conda install for local and channel based artifacts into one env create call #422

rapids-bot merged 10 commits into from
Oct 1, 2025

Conversation

@rgsl888prabhu
Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu commented Sep 30, 2025

Description

Earlier we created env with nightly packages first and then install local dependency later, but this can create issue with dependency and also take time to do it twice. Combing them in one will save time and edge cases.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu added this to the 25.10 milestone Sep 30, 2025
@rgsl888prabhu rgsl888prabhu self-assigned this Sep 30, 2025
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner September 30, 2025 15:53
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Sep 30, 2025
@rgsl888prabhu rgsl888prabhu requested a review from vyasr September 30, 2025 15:53
@rgsl888prabhu rgsl888prabhu requested a review from bdice September 30, 2025 15:55
@rgsl888prabhu
Copy link
Collaborator Author

rgsl888prabhu commented Sep 30, 2025 •
edited
Loading

Currently testing with the fix, also updated pr.yaml so I can trigger only conda, will remove those changes after this test.

@rgsl888prabhu
Copy link
Collaborator Author

rgsl888prabhu commented Sep 30, 2025

The issue has been fixed

cuopt                               25.10.00a95      cuda12_py313_250930_f93731b0  file:///tmp/tmp.MRcymqEQ3R
cuopt-mps-parser                    25.10.00a95      py313_250930_f93731b0         file:///tmp/tmp.MRcymqEQ3R
cuopt-server                        25.10.00a95      py313_250930_f93731b0         file:///tmp/tmp.MRcymqEQ3R
cuopt-sh-client                     25.10.00a95      py313_250930_f93731b0         file:///tmp/tmp.MRcymqEQ3R

https://github.com/NVIDIA/cuopt/actions/runs/18142352669/job/51641202842?pr=422#step:10:1547

bdice
bdice approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for taking this on @rgsl888prabhu!

@rgsl888prabhu
Copy link
Collaborator Author

rgsl888prabhu commented Oct 1, 2025

/merge

@rapids-bot rapids-bot bot merged commit 2a6da95 into NVIDIA:branch-25.10 Oct 1, 2025
172 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmckayus tmckayus tmckayus approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from NVIDIA/cuopt-ci-codeowners

Assignees

@rgsl888prabhu rgsl888prabhu

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

25.10

Development

Successfully merging this pull request may close these issues.

3 participants

@rgsl888prabhu @tmckayus @bdice