Forward-merge release/25.12 into main #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes errouneous logic in the simple rounding and edge cases causing supposedly integer solutions to contain fractional variables. RINS fixes are also included (wrong problem pointer being used for some checks). Also, it seems that the cuSparse CSR-to-CSC routine occasionally produces an incorrect output transpose. As a workaround, a manual transpose implementation is used instead. Further work will be required to identify a more easily reproducible example and identify the underlying issue (and/or file a cuSparse bug) ## Summary by CodeRabbit * **Bug Fixes** * Improved numerical robustness with tighter clamping, added bounds checks, and reduced spurious runtime assertions. * **Performance Improvements** * Faster matrix transpose and improved GPU rounding kernels for better throughput. * **Stability** * Consistent use of copied problem state during heuristics and safer handling of bound/rounding edge cases. * **Behavioral** * Rounding and feasibility flows now enforce post-clamp validation and per-variable locking/decision logic. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> Authors: - Alice Boucher (https://github.com/aliceb-nv) Approvers: - Rajesh Gandham (https://github.com/rg20) URL: #670
Contributor
Author
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/25.12 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.