Skip to content

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Dec 31, 2025

Contributes to rapidsai/build-planning#152

Proposes the following changes, to prevent builds breaking when Python build backends
start to require configuration consistent with PEP 639 (link):

  • using SPDX identifiers in [project].license
  • moving [tool.setuptools].license-files to [project].license-files
  • removing License :: trove classifiers
  • bumping build backend floors (setuptools>=77.0.0 and / or scikit-build-core>=0.11.0)

Summary by CodeRabbit

  • Chores
    • Updated build tool dependencies for improved compatibility and stability.
    • Modernized license declarations across project configuration files.
    • Added documentation dependencies for enhanced documentation generation.

✏️ Tip: You can customize this high-level summary in your review settings.

@jameslamb jameslamb added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Dec 31, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 31, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@@ -1,20 +0,0 @@
# SPDX-FileCopyrightText: Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
Copy link
Member Author

@jameslamb jameslamb Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was not actually getting packaged, because it's only referenced in a setup.cfg file but cuopt_mps_parser is built with scikit-build-core (which ignores such files).

mkdir -p ./delete-me
pip download \
  --no-deps \
  -d ./delete-me \
  --index-url https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/ \
  'cuopt-mps-parser>=26.2.0a84'
$ unzip -l ./delete-me/cuopt*.whl | grep -i license
        0  2025-12-30 15:26   cuopt_mps_parser-26.2.0a84.dist-info/licenses/
    11348  2025-12-30 15:26   cuopt_mps_parser-26.2.0a84.dist-info/licenses/LICENSE

This PR proposes removing this left-behind file and the setup.cfg.

But please let me know if it was intended to be included... I noticed it's the MIT license and the LICENSE files throughout the rest of the repo are Apache 2.0.

@jameslamb jameslamb changed the title WIP: Use SPDX license identifiers in pyproject.toml, bump build dependency floors Use SPDX license identifiers in pyproject.toml, bump build dependency floors Dec 31, 2025
@jameslamb jameslamb marked this pull request as ready for review December 31, 2025 18:18
@jameslamb jameslamb requested review from a team as code owners December 31, 2025 18:18
@coderabbitai

This comment was marked as spam.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine once the cuOpt team confirms the intended linear_programming license.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 2da7b39 into NVIDIA:main Dec 31, 2025
92 checks passed
@jameslamb jameslamb deleted the pep-639-updates branch December 31, 2025 21:38
@coderabbitai coderabbitai bot mentioned this pull request Jan 2, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants