-
Notifications
You must be signed in to change notification settings - Fork 105
Use SPDX license identifiers in pyproject.toml, bump build dependency floors #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
| @@ -1,20 +0,0 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was not actually getting packaged, because it's only referenced in a setup.cfg file but cuopt_mps_parser is built with scikit-build-core (which ignores such files).
mkdir -p ./delete-me
pip download \
--no-deps \
-d ./delete-me \
--index-url https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/ \
'cuopt-mps-parser>=26.2.0a84'$ unzip -l ./delete-me/cuopt*.whl | grep -i license
0 2025-12-30 15:26 cuopt_mps_parser-26.2.0a84.dist-info/licenses/
11348 2025-12-30 15:26 cuopt_mps_parser-26.2.0a84.dist-info/licenses/LICENSEThis PR proposes removing this left-behind file and the setup.cfg.
But please let me know if it was intended to be included... I noticed it's the MIT license and the LICENSE files throughout the rest of the repo are Apache 2.0.
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine once the cuOpt team confirms the intended linear_programming license.
|
/merge |
Contributes to rapidsai/build-planning#152
Proposes the following changes, to prevent builds breaking when Python build backends
start to require configuration consistent with PEP 639 (link):
[project].license[tool.setuptools].license-filesto[project].license-filesLicense ::trove classifierssetuptools>=77.0.0and / orscikit-build-core>=0.11.0)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.