FAISS with cuVS enabled in cuvs-bench#561
Merged
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
tarang-jain
added
non-breaking
cjnolet
reviewed
Jan 9, 2025
achirkin
requested changes
Jan 10, 2025
achirkin
left a comment
achirkin
left a comment
Contributor
There was a problem hiding this comment.
Here are couple suggestions on my side to keep the faiss behavior in line with other algorithms.
cjnolet
reviewed
Jan 16, 2025
achirkin
reviewed
Jan 22, 2025
cjnolet
approved these changes
Jan 24, 2025
achirkin
reviewed
Jan 27, 2025
achirkin
approved these changes
Jan 27, 2025
achirkin
left a comment
achirkin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates, no more complaints on my side :)
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly adapted from NVIDIA/raft#2026