Add python and rust bindings for Ivf-Flat#82
Conversation
benfred
added
improvement
dantegd
left a comment
dantegd
left a comment
There was a problem hiding this comment.
Quick review of the python side, things look good overall there!
| kmeans_n_iters : int, default = 20 | ||
| The number of iterations searching for kmeans centers during index | ||
| building. | ||
| kmeans_trainset_fraction : int, default = 0.5 |
There was a problem hiding this comment.
I wonder if adding a suggestion of when to change this would be useful for users
There was a problem hiding this comment.
I think it could be very helpful! Though - I'm not sure of when to change this myself, and have just copied this comment from the c++ api. Do you have any thoughts here?
There was a problem hiding this comment.
Assuming we are talking about kmeans_n_iters here, this question has actually come up quite a bit- and more recently in discussions with some of our partners. @benfred what do you think about adding a quick blurb like The default setting is often fine, but this parameter can be decreased to improve training time wih larger trainset fractions (10M+ vectors) or increased for smaller trainset fractions (very small number of vectors) to improve recall.
Co-authored-by: Dante Gama Dessavre <dante.gamadessavre@gmail.com>
…into ivf_flat_python_rust
dantegd
left a comment
dantegd
left a comment
There was a problem hiding this comment.
looks great from my side!
|
/merge |
3 participants
No description provided.