#89 - Make Manager::shutdown() idempotent to prevent post-finalize log crash

[RamyaGuru]

Fixes #89. `Manager::shutdown()` was being invoked twice in the bench lifecycle, and the second call's top `DAQIRI_LOG_INFO` crashed because spdlog's default logger had already been destroyed by `__cxa_finalize`.

Adds a 1-line idempotency guard (`if (!initialized_) return;`) at the top of `RdmaMgr::shutdown()`, `DpdkMgr::shutdown()`, and `SocketMgr::shutdown()`. Same log-first body-second pattern in all three managers, same fix.
`DpdkMgr`'s existing `num_init` reference-counted body is preserved — the guard only activates after the body has cleared `initialized_` on the final shutdown.

Test plan

• A/B verified on a clean fix-branch base (off `origin/main`):
  • With fix → `daqiri_bench_rdma --mode both` exits 0.
  • Without fix (reset to `origin/main`) → bench segfaults during `__cxa_finalize` (exit 139). Confirms the fix is necessary on plain main, not just under the perf-report branch's bench changes.
• DPDK / Socket benches still shut down cleanly (no regression — `num_init` ref counting in DpdkMgr preserved).

Discovered while tackling PR #72.

[greptile-apps]

Greptile Summary

This PR adds a one-line idempotency guard to DpdkMgr::shutdown(), RdmaMgr::shutdown(), and SocketMgr::shutdown() to prevent a segfault that occurred when __cxa_finalize invoked the destructor chain a second time after spdlog's default logger had already been torn down.

• DpdkMgr / RdmaMgr receive a simple if (!initialized_) { return; } guard, consistent with each manager's existing practice of clearing initialized_ at the end of the shutdown body.
• SocketMgr uses a dual-flag guard (if (!initialized_ && !running_.load()) { return; }) to preserve the init-failure cleanup path: initialize() sets running_=true before setup and initialized_=true only on success, so a throw mid-setup calls shutdown() with initialized_=false, running_=true — a state that must fall through to join any partially-spawned threads, avoiding std::terminate in the destructor cascade.

Confidence Score: 5/5

Safe to merge — three small, well-isolated guards that each fire only after the corresponding manager has fully torn itself down.

The change is minimal: one guard per manager, each guarding on the flag that the shutdown body already clears. The SocketMgr variant correctly uses a dual-flag check to preserve the init-failure cleanup path, as confirmed by reading initialize(). The ref-counted DpdkMgr body is untouched. The previous outside-diff concern about a dead secondary guard has been resolved by this commit's tightened condition and removal of the old guard position.

No files require special attention.

Important Files Changed

Filename	Overview
src/managers/dpdk/daqiri_dpdk_mgr.cpp	Adds if (!initialized_) { return; } guard before the first log call; initialized_ is only cleared when the ref-count num_init reaches zero, so the guard does not interfere with normal ref-counted shutdown sequences.
src/managers/rdma/daqiri_rdma_mgr.cpp	Adds if (!initialized_) { return; } guard at the top; initialized_ is cleared at the end of the shutdown body, so a post-finalize re-entry exits immediately without touching the destroyed spdlog logger.
src/managers/socket/daqiri_socket_mgr.cpp	Guard moved from below the RoCE branch to the top of the function, and strengthened to if (!initialized_ && !running_.load()) { return; } so that the init-failure cleanup path (running_=true, initialized_=false) still falls through and joins any partially-spawned threads.

Sequence Diagram

sequenceDiagram
    participant App
    participant Manager
    participant spdlog

    App->>Manager: explicit shutdown()
    Note over Manager: guard: initialized_=true → pass
    Manager->>spdlog: DAQIRI_LOG_INFO(...)
    Manager->>Manager: cleanup body
    Manager->>Manager: "initialized_ = false"

    Note over spdlog: __cxa_finalize destroys default logger

    Manager->>Manager: ~Manager() → shutdown()
    Note over Manager: guard: initialized_=false → return immediately
    Note over spdlog: (no log call — crash prevented)

Loading

_{Reviews (2): Last reviewed commit: "#89 - Tighten SocketMgr::shutdown() guar..." | Re-trigger Greptile}