fix(chart): normalize MQTT stream sources#29
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
FrankSpitulski
force-pushed
the
fix/chart/6230686-cpc-mqtt-streams
branch
2 times, most recently
from
d945e99 to
c36ef60
Compare
FrankSpitulski
changed the title
FrankSpitulski
force-pushed
the
fix/chart/6230686-cpc-mqtt-streams
branch
from
c36ef60 to
0ce5ede
Compare
FrankSpitulski
changed the title
FrankSpitulski
force-pushed
the
fix/chart/6230686-cpc-mqtt-streams
branch
from
0ce5ede to
116e890
Compare
Render empty source transform destinations explicitly. This matches the Stream specs that NACK writes back in control-loop mode. Keep the NACK control loop enabled. Signed-off-by: Frank Spitulski <fspitulski@nvidia.com>
FrankSpitulski
force-pushed
the
fix/chart/6230686-cpc-mqtt-streams
branch
from
116e890 to
b046c54
Compare
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-05-28 10:04:57 UTC | Commit: b046c54 |
🛡️ CodeQL Analysis✅ No security issues found! 💡 Note: Enable GitHub Advanced Security to see full details in the Security tab. 🕐 Last updated: 2026-05-28 10:06:02 UTC | Commit: b046c54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--force-conflictsfallback for actual source/topology changes where NACK owns existing Stream fields.NVBug
6230686
Root cause
NACK normalizes omitted subject transform destinations to
dest: "". Helm previously rendered those as absent. After NACK took ownership ofspec.sources, a no-op Helm upgrade attempted to change the field back to absent and hit an SSA conflict.Upstream check
nackchart0.33.2, app0.22.2.0.34.0, app0.23.0; no relevant managed-field/source normalization fix found.Validation
git diff --check origin/main...HEADhelm lint deploy/nats-event-bushelm template nats-event-bus deploy/nats-event-bus --namespace event-bus -f local/nats/k8s/local-dev-values.yaml -f local/nats/k8s/cpc/values.yaml -f local/nats/k8s/cpc/cpc-1.yaml --show-only templates/mqtt-streams.yamlmake checkmake clean-e2e,make -C local setup-infra,make -C local deploy-natsmake test-e2e: functional passed; performance passed with 12 passed, 0 failedhelm upgradepassed onkind-cpc-1andkind-cpc-2, both revision 2