Skip to content

Adding some claude tools for claude / cursor#757

Merged
NickGeneva merged 4 commits intoNVIDIA:mainfrom
NickGeneva:ngeneva/claud_setup
Mar 19, 2026
Merged

Adding some claude tools for claude / cursor#757
NickGeneva merged 4 commits intoNVIDIA:mainfrom
NickGeneva:ngeneva/claud_setup

Conversation

@NickGeneva
Copy link
Collaborator

Earth2Studio Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.
  • Assess and address Greptile feedback (AI code review bot for guidance; use discretion, addressing all feedback is not required).

Dependencies

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 18, 2026

Greptile Summary

This PR adds AI-assistant tooling for Claude Code and Cursor: seven slash-command definitions under .claude/commands/, a new CLAUDE.md project guide, a new Cursor rule e2s-013-assimilation-models.mdc covering data assimilation (DA) model conventions, and .gitignore entries to prevent Claude agent state from being committed. All referenced cursor rule files (e2s-000 through e2s-013) exist in the repository, and the command scripts correctly map to the existing make targets.

  • All .claude/commands/ files accurately reflect the project's make targets and tox environments.
  • CLAUDE.md is a clean, accurate index of the cursor rules and key project conventions.
  • .gitignore correctly excludes .claude/agent-memory and .claude/agents.
  • e2s-013-assimilation-models.mdc is a comprehensive DA model guide, but the init_coords code example contains unreachable code (a second return statement after return None) and the stateful branch uses a bare OrderedDict instead of the CoordSystem(OrderedDict(...)) wrapper used everywhere else in the file — both of which could mislead an AI agent or developer who follows the example literally.

Confidence Score: 5/5

  • Safe to merge; all changes are documentation and tooling configuration with no impact on production code.
  • No production Python code is modified. The only non-trivial change is the new Cursor rule, which has a minor documentation inconsistency in an example code block but does not affect runtime behaviour.
  • .cursor/rules/e2s-013-assimilation-models.mdc — unreachable code and missing CoordSystem wrapper in the init_coords example.

Important Files Changed

Filename Overview
CLAUDE.md New Claude Code guide referencing all cursor rules (e2s-000 to e2s-013); all referenced rule files exist in the repo; content is accurate and well-structured.
.cursor/rules/e2s-013-assimilation-models.mdc New Cursor rule for DA model implementation; comprehensive and accurate, but the init_coords code example contains unreachable code and a missing CoordSystem wrapper in the stateful branch.
.gitignore Adds .claude/agent-memory and .claude/agents to gitignore to prevent Claude agent state from being committed; appropriate change.
.claude/commands/test.md Detailed slash command for running tox test environments; tox env table and usage instructions look correct and well-documented.

Last reviewed commit: "Merge branch 'main' ..."

@NickGeneva
Copy link
Collaborator Author

/blossom-ci

1 similar comment
@NickGeneva
Copy link
Collaborator Author

/blossom-ci

@NickGeneva NickGeneva merged commit bc52726 into NVIDIA:main Mar 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants