Skip to content

fix(themes): refactor conversions and fix out of bound colors #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coryrylan merged 2 commits into from
May 18, 2026
Merged

fix(themes): refactor conversions and fix out of bound colors #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa9efe
fix(themes): refactor conversions and fix out of bound colors
coryrylan May 15, 2026
771fe5e
chore(core): update snapshots
coryrylan May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/core/.visual/textarea.dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions projects/core/.visual/textarea.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion projects/core/src/card/card.test.visual.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function template(theme: '' | 'dark' = '') {
•︎•︎•︎
</nve-card-content>
<nve-card-footer>
<nve-button container="flat" style="margin-left: auto">•︎•︎•︎</nve-button>
<nve-button style="margin-left: auto">•︎•︎•︎</nve-button>
</nve-card-footer>
</nve-card>
</div>
Expand Down
12 changes: 6 additions & 6 deletions projects/core/src/textarea/textarea.test.visual.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ function template(theme: '' | 'dark' = '') {
import '@nvidia-elements/core/textarea/define.js';
document.documentElement.setAttribute('nve-theme', '${theme}');
</script>
<style>
/* platform specific styles */
nve-textarea textarea {
resize: none;
}
</style>

<nve-textarea>
<label>•︎•︎•︎•︎•︎•︎</label>
Expand Down Expand Up @@ -52,11 +58,5 @@ function template(theme: '' | 'dark' = '') {
<textarea></textarea>
<nve-control-message>•︎•︎•︎•︎•︎•︎</nve-control-message>
</nve-textarea>

<nve-textarea>
<label>•︎•︎•︎•︎•︎•︎</label>
<textarea rows="15" cols="40"></textarea>
<nve-control-message>•︎•︎•︎•︎•︎•︎</nve-control-message>
</nve-textarea>
Copy link
Copy Markdown
Collaborator Author

@coryrylan coryrylan May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The row/cols and resize styles were causing flakey tests due to platform differences

`;
}
1 change: 1 addition & 0 deletions projects/site/src/_11ty/layouts/docs.11ty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export async function render(data) {
${data.tag && !data.hideStatus && !(data.page.url.includes('api') || data.page.url.includes('examples')) ? `${elementStatus(data.tag)}` : ''}
</div>
</main>
<!-- ANCHOR-GENERATOR -->
<nve-page-panel closable hidden slot="right-aside" size="sm" id="system-options-panel">
<nve-page-panel-content>
<nvd-system-settings></nvd-system-settings>
Expand Down
Loading