fix: improve goreleaser tag selection and changelog grouping#144
fix: improve goreleaser tag selection and changelog grouping#144jingxiang-z merged 1 commit intomainfrom
Conversation
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
📝 WalkthroughWalkthroughTwo configuration files updated to enhance the release process: an environment variable added to the GitHub Actions release workflow to pass the current Git tag reference to GoReleaser, and changelog grouping regex patterns in GoReleaser configuration made more permissive to better match conventional commit keywords. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.goreleaser.yaml:
- Around line 190-202: The changelog grouping regexes are too permissive (they
use '.*\b...') and can match tokens anywhere in the commit/title; update each
regexp entry (the ones currently set to '.*\bfeat(?:\([^)]+\))?!?:',
'.*\bfix(?:\([^)]+\))?!?:', '.*\bperf(?:\([^)]+\))?!?:',
'.*\bdocs(?:\([^)]+\))?!?:', '.*\brefactor(?:\([^)]+\))?!?:') to anchor to the
start of the string and only allow the conventional prefix format (e.g. begin
with ^ and then feat|fix|perf|docs|refactor with optional scope and optional
breaking mark before the colon) so these tokens are matched only when they are
the actual commit-type prefix.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: daadecd6-85de-4f83-9939-f9992c8ceabc
📒 Files selected for processing (2)
.github/workflows/release.yml.goreleaser.yaml
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Summary
Notes
Summary by CodeRabbit