chore: prune unused vendored sdk packages#161
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (3)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request removes the fleet-intelligence-sdk third-party codebase entirely, including all v1 client implementations, CLI command handlers, NVIDIA GPU monitoring components, and supporting utilities. Minor changes include dependency updates in Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
d2c93d7 to
7449240
Compare
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
What changed
third_party/fleet-intelligence-sdk/cmdNOTICEto remove references to deleted embedded third-party filesWhy
Customers raised concerns about logic present in the vendored SDK. This change reduces the vendored surface area to the subset still used by the fleet intelligence agent, removing unused commands and packages while preserving current agent behavior.
Impact
Validation
env HOME=/tmp/fleetint-home GOCACHE=/tmp/fleetint-gocache GOPATH=/tmp/fleetint-gopath go test -mod=mod ./cmd/fleetint ./internal/...Summary by CodeRabbit
Release Notes
Refactor
Dependencies