Skip to content

chore: disable accelerator-nvidia-processes by default#209

Merged
ambermingxin merged 3 commits into
mainfrom
feat/disable-process-component
May 27, 2026
Merged

chore: disable accelerator-nvidia-processes by default#209
ambermingxin merged 3 commits into
mainfrom
feat/disable-process-component

Conversation

@ambermingxin
Copy link
Copy Markdown
Collaborator

@ambermingxin ambermingxin commented May 27, 2026

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Removed the accelerator-nvidia-processes entry from the NVIDIA GPU "Available component names" list.
  • Chores
    • Removed the NVIDIA GPU “processes” component from the product; it is no longer listed or available to enable.

Review Change Stack

Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

📝 Walkthrough

Walkthrough

The PR removes the accelerator-nvidia-processes component from the registry, updates docs to remove it from the NVIDIA component list and clarify default selection behavior, and updates tests to assert the component is absent.

Changes

Component removal and docs

Layer / File(s) Summary
Docs: remove component name and clarify defaults
docs/configuration.md
Removes accelerator-nvidia-processes from the NVIDIA "Available component names" list and clarifies that an empty --components selects the built-in default set.
Registry: remove import and component entry
internal/registry/registry.go
Removes the componentsprocesses import, updates the NVIDIA GPU comment about defaults, and deletes the componentsprocesses entry from All(), so the component is no longer registered or discoverable.
Tests: expect component absent
internal/registry/registry_test.go
Adds accelerator-nvidia-processes to the list of removed components checked by TestRemovedComponentsAbsent, expecting GetComponent to return nil.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

A rabbit nibbles docs and hops away,
The processes name is gone today;
Registry pruned, tests glance and say,
Defaults stay neat, no stray display. 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately reflects the main objective of the pull request: removing the accelerator-nvidia-processes component from the registry and related code, which effectively disables it by default.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/disable-process-component

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57c12fce78

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/registry/registry.go Outdated
Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
@jingxiang-z
Copy link
Copy Markdown
Collaborator

The title should be a chore, it's not a new feature. Other than this, it looks good to me.

@ambermingxin ambermingxin changed the title feat: disable accelerator-nvidia-processes by default chore: disable accelerator-nvidia-processes by default May 27, 2026
@ambermingxin ambermingxin merged commit 7ef5e75 into main May 27, 2026
9 checks passed
@ambermingxin ambermingxin deleted the feat/disable-process-component branch May 27, 2026 18:02
ambermingxin added a commit that referenced this pull request May 27, 2026
Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
@coderabbitai coderabbitai Bot mentioned this pull request May 28, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants