bug: fix logic flip bug in encoding detection, add tests to catch#1711
Merged
Conversation
Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
leondz
added
bug
leondz
changed the title
jmartin-tech
approved these changes
Apr 28, 2026
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
Makes sense, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logic flip around case-sensitivity in
detectors.encoding.DecodeApprox. Hit rates are expected to go up.Tidy up tests for this module & add case sensitivity tests.
Resolves #1700
Mild conflict with refactor in #1538