helm: add support for extra Manifests #1992
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enneitex
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
Signed-off-by: Etienne DIVET <etienne.divet@enedis.fr>
enneitex
force-pushed
the
helm-extra-objects
branch
from
c2543d0 to
8dccc8f
Compare
Contributor
|
/ok-to-test 8dccc8f |
Author
|
Hey, let me know if I can do anything to help this PR get merged |
tariq1890
approved these changes
Jan 7, 2026
rajathagasthya
approved these changes
Jan 7, 2026
Contributor
rajathagasthya
left a comment
rajathagasthya
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution.
rahulait
approved these changes
Jan 7, 2026
Contributor
rahulait
left a comment
rahulait
left a comment
There was a problem hiding this comment.
LGTM, was able to render additional yamls using this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for extra Manifest in the helm chart.
Use case: in air gap mode, I need to create a repo-config configmap. This change allows me to define the configmap directly in the chart.
similar implementation is present in argocd, prometheus, ESO etc...