[gpu-feature-discovery] disable nodefeature API for openshift clusters #2066
+128
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
shivamerla
as code owners
cdesiniotis
reviewed
Jan 24, 2026
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
LGTM. Let's add a test case for this.
Contributor
tariq1890
force-pushed
the
gfd-disable-nfapi-for-ocp
branch
from
60d1472 to
a1f510d
Compare
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
gfd-disable-nfapi-for-ocp
branch
from
a1f510d to
63cb7ae
Compare
rajathagasthya
approved these changes
Jan 26, 2026
cdesiniotis
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to unblock GFD in OpenShift clusters.
With the recent change in GFD where the NodeFeature API was enabled by default, we observed that the latest GFD images were not writing the gpu feature labels to the node on OpenShift clusters. After further analysis, we found that the NFD that comes in OpenShift clusters still leverage gRPC as opposed to the
NodeFeatureCustom Resource