new privileges for sandbox-device-plugin#2078
Merged
cdesiniotis merged 1 commit intoNVIDIA:mainfrom Feb 4, 2026
Merged
Conversation
rajatchopra
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
tariq1890
reviewed
Jan 28, 2026
rajatchopra
force-pushed
the
gfd_in_sandbox_dp
branch
3 times, most recently
from
0bbce4b to
32db083
Compare
rajatchopra
force-pushed
the
gfd_in_sandbox_dp
branch
2 times, most recently
from
57bafec to
7ba8fae
Compare
elezar
reviewed
Feb 3, 2026
elezar
reviewed
Feb 3, 2026
Member
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
From my perspective it is not clear how other GFD-specific configs are applied. For example, what about connecting to the NodeFeature API? What about the timeout? What about sharing?
rajatchopra
force-pushed
the
gfd_in_sandbox_dp
branch
2 times, most recently
from
a0808f9 to
495f2af
Compare
tariq1890
approved these changes
Feb 4, 2026
cdesiniotis
reviewed
Feb 4, 2026
rajatchopra
force-pushed
the
gfd_in_sandbox_dp
branch
from
495f2af to
c5c8dd9
Compare
cdesiniotis
reviewed
Feb 4, 2026
…privileges and info Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
rajatchopra
force-pushed
the
gfd_in_sandbox_dp
branch
from
c5c8dd9 to
c725eef
Compare
cdesiniotis
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sandbox-device-plugin will launch the GFD job within the sandbox env, so we need new privileges for it to do so
Changes:
GFD launch PR in sandbox-device-plugin: NVIDIA/sandbox-device-plugin#30
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Manual testing on cluster