Merged
Conversation
cdesiniotis
requested review from
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
cdesiniotis
force-pushed
the
bump-go-1.26.0
branch
from
4c34686 to
af5b8ac
Compare
tariq1890
previously approved these changes
Mar 5, 2026
Contributor
|
Can you update the Dockerfile too? |
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
force-pushed
the
bump-go-1.26.0
branch
from
af5b8ac to
d34c3c9
Compare
tariq1890
approved these changes
Mar 5, 2026
Contributor
Author
Good catch. Updated. Ideally the Go version in the Dockerfile would be parameterized so that we only have to update the version in one place. |
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by #2180