fix: driver and toolkit ready state file cleanup#2242
Open
Conversation
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
ae75ec3 to
21d3d41
Compare
Contributor
Author
|
PTAL @rahulait @rajathagasthya |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix stale readiness file handling for driver and toolkit operands during restart/upgrade flows.
During upgrade, the old driver-ready and toolkit-ready files can remain on the host because unlike .driver-ctr-ready, they were not being cleaned up during pod shutdown.
mig-manager only waits for those files to exist, not for new validation of the new driver/toolkit state.
So after driver reinstall: mig-manager can start using old ready signals before the new driver/toolkit libraries are actually available.
files are only deleted when the corresponding validator runs again:
toolkit-ready :
driver-ready:
The patch fixes that by cleaning up driver-ready and toolkit-ready file.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Reproduction in a test environment was not possible because the issue appears to be timing-dependent and hard to reproduce reliably.
Validation for this change was done by code-path analysis.
I will perform manual validation on hardware with MIG-capable GPUs