Skip kata manager processing#2407
Open
rajatchopra wants to merge 3 commits intoNVIDIA:mainfrom
Open
Conversation
rajatchopra
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
rajatchopra
changed the title
Contributor
Author
|
Fixes #2398 |
rajatchopra
changed the title
rahulait
reviewed
Apr 28, 2026
rahulait
reviewed
Apr 28, 2026
rahulait
reviewed
Apr 28, 2026
| return n.sandboxEnabled && clusterPolicySpec.SandboxDevicePlugin.IsEnabled() && clusterPolicySpec.SandboxWorkloads.Mode == string(gpuv1.KubeVirt) | ||
| case "state-kata-device-plugin": | ||
| return n.sandboxEnabled && clusterPolicySpec.KataSandboxDevicePlugin.IsEnabled() && clusterPolicySpec.SandboxWorkloads.Mode == string(gpuv1.Kata) | ||
| case "state-kata-manager": |
Contributor
There was a problem hiding this comment.
Should this also be removed?
Contributor
Author
There was a problem hiding this comment.
This probably not. Its double checking for enabled or not. Unless we ensure that the state is never created.
rahulait
reviewed
Apr 28, 2026
rahulait
reviewed
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Is this code still in use?
Contributor
Author
There was a problem hiding this comment.
can be removed 👍
rahulait
reviewed
Apr 28, 2026
… enabled=false Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
…t kata manager state is not created ever
rajatchopra
force-pushed
the
deprecatekatamanager
branch
from
ad3fea3 to
87a65f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not process anything about kata manager. The operand stands deprecated. Any changes to cluster policy with respect to that section must not be responded to. Remove it from state manager.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Manual testing on cluster with kataManager enabled=true manually on the CRD.
Prior to this fix, there is a panic in the logs. After the fix in this PR, it runs clean.