Conversation
Pull Request Test Coverage Report for Build 15386595059Details
💛 - Coveralls |
shivakunv
force-pushed
the
reboottimeoutcheck
branch
2 times, most recently
from
f2a7146 to
29345c2
Compare
ArangoGutierrez
requested changes
Jun 2, 2025
| interval := 60 * time.Second | ||
| retryInterval := 30 * time.Second | ||
|
|
||
| time.Sleep(interval) |
Collaborator
There was a problem hiding this comment.
this is outside of the foor loop, why?
pkg/provisioner/provisioner.go
Outdated
Comment on lines
96
to
97
| maxRetries := 9 | ||
| interval := 60 * time.Second |
|
|
||
| # Wait for cluster to be ready | ||
| with_retry 10 30s kubectl --kubeconfig $KUBECONFIG wait --for=condition=ready --timeout=300s nodes --all | ||
| with_retry 5 300s kubectl --kubeconfig $KUBECONFIG wait --for=condition=ready --timeout=300s nodes --all |
Collaborator
There was a problem hiding this comment.
I prefer more retries with a smaller time window, waiting 300s makes it too slow, every 30s is ok. the command is also calling kubectl to wait 300s so 10 x 30s + 300s is enough time already
shivakunv
force-pushed
the
reboottimeoutcheck
branch
3 times, most recently
from
4cfdb3c to
dff8333
Compare
Signed-off-by: shiva kumar <shivaku@nvidia.com>
Signed-off-by: shiva kumar <shivaku@nvidia.com>
shivakunv
force-pushed
the
reboottimeoutcheck
branch
from
dff8333 to
afae7c5
Compare
Collaborator
|
I we are safe to close this PR |
Contributor
Author
|
Thanks @ArangoGutierrez closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.