fix(scp): log SFTP MkdirAll error instead of discarding #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses an audit finding in the holodeck scp CLI command by making SFTP remote directory creation failures diagnosable, without changing the operation to be fatal.
Changes:
- Replaced a silently discarded
sftp.Client.MkdirAllerror with a warning log. - Kept directory creation as best-effort to avoid turning a non-critical failure into a hard error.
Pull Request Test Coverage Report for Build 21960972397Details
💛 - Coveralls |
The error was silently discarded with '_ ='. Log it as a warning so permission-denied or disk-full errors are diagnosable. Audit finding NVIDIA#26 (LOW). Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
ArangoGutierrez
force-pushed
the
fix/scp-mkdir-error
branch
from
68df94e to
94d3713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_ = client.MkdirAll(remoteDir)) with a warning log so permission-denied or disk-full errors are diagnosableAudit Finding
cmd/cli/scp/scp.go:221Changes
cmd/cli/scp/scp.go: LogMkdirAllerror as warning instead of discarding with_ =Test plan
gofmt— no formatting issuesgolangci-lint run ./...— 0 issuesgo test -coverprofile=coverage.out ./pkg/...— all tests passgo build -o bin/holodeck cmd/cli/main.go— compilesgo mod tidy && go mod verify— all modules verified