perf: inject sleep function to speed up AWS provider tests (~200x)#739
Merged
ArangoGutierrez merged 2 commits intomainfrom Mar 26, 2026
Merged
perf: inject sleep function to speed up AWS provider tests (~200x)#739ArangoGutierrez merged 2 commits intomainfrom
ArangoGutierrez merged 2 commits intomainfrom
Conversation
Replace all time.Sleep calls in Provider with injectable p.sleep field, defaulting to time.Sleep in production and noopSleep in tests. This eliminates ~430s of real wall-clock delays in unit tests (retry backoff, NAT gateway polling, verification delays) bringing the AWS provider test suite from ~433s down to ~2s. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Pull Request Test Coverage Report for Build 23530118464Details
💛 - Coveralls |
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sleep func(time.Duration)field toProviderstruct, defaulting totime.Sleepin productionWithSleepfunctional option for test injectiontime.Sleep()calls increate.goanddelete.gowithp.sleep()noopSleep(no-op) in all test files to eliminate real wall-clock delaysImpact
time.Sleep)Test plan
go test ./...passes (only E2E skipped due to missing env)TestDeleteRetryBackofftracks sleep calls correctly with injected function