build: expand test coverage scope to cmd/, api/, and internal/#750
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom Mar 30, 2026
Merged
Conversation
Extend the go test coverage profile to include ./cmd/..., ./api/..., and ./internal/... in addition to ./pkg/..., so that unit tests in all four package trees contribute to the Coveralls report. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testMakefile target to rungo testwith coverage across all four package trees:./pkg/...,./cmd/...,./api/..., and./internal/....github/workflows/golang.yamlalready delegates tomake coveragePackages with test files added to coverage scope
cmd/cli/- 12 test files (dryrun, update, delete, status, describe, common, cleanup, list, scp, create)api/holodeck/v1alpha1/- 2 test files (types, validation)internal/- 3 test files (ami/resolver, logger, instances)Test plan
make coveragepasses with the expanded scope