Fix bug in NVIDIA Driver install script when package version is specified#782
Open
cdesiniotis wants to merge 2 commits intomainfrom
Open
Fix bug in NVIDIA Driver install script when package version is specified#782cdesiniotis wants to merge 2 commits intomainfrom
cdesiniotis wants to merge 2 commits intomainfrom
Conversation
Coverage Report for CI Build 24748725397Coverage remained the same at 47.77%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
ArangoGutierrez
requested changes
Apr 21, 2026
Collaborator
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Thanks for the PR Chris! I truly appreciate it :)
Comment on lines
+24
to
+25
| package: | ||
| version: 580.95.05 |
Collaborator
There was a problem hiding this comment.
The current NVIDIADriver API on main (api/holodeck/v1alpha1/types.go:433) exposes driver version as a top-level field:
nvidiaDriver:
install: true
version: 580.95.05
Author
There was a problem hiding this comment.
I made this change because of this comment which says the top-level field is deprecated in favor of nvidiaDriver.package.version:
holodeck/api/holodeck/v1alpha1/types.go
Line 599 in f3eddc4
| version: 580.95.05 | ||
| kubernetes: | ||
| install: true | ||
| installer: kubeadm No newline at end of file |
cdesiniotis
force-pushed
the
fix-driver-package-version
branch
from
33e02d8 to
84488da
Compare
cdesiniotis
changed the title
cdesiniotis
force-pushed
the
fix-driver-package-version
branch
2 times, most recently
from
6cbaa4d to
4b035b2
Compare
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
…fied Before this change, when nvidiaDriver.package.version was specified, holodeck was not populating the package version correctly. As a result, the package installation failed. For example, one would see error messages like: sudo DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends cuda-drivers=580.95.05 E: Version '580.95.05' for 'cuda-drivers' was not found This commit ensures we construct the package version string correctly by adding the '-*' suffix to the version string. Fixes #783 Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
force-pushed
the
fix-driver-package-version
branch
from
4b035b2 to
bd9b9d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, when nvidiaDriver.package.version was specified,
holodeck was not populating the package version correctly. As a result,
the package installation failed. For example, one would see error messages
like:
This commit ensures we construct the package version string correctly
by adding the '-*' suffix to the version string.
Fixes #783