Skip to content

feat: forge vault_client hard codes trust_domain and namespace #1867

@ianderson-nvidia

Description

@ianderson-nvidia

Is this a new feature, an enhancement, or a change to existing functionality?

Enhancement

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

https://github.com/NVIDIA/infra-controller/blob/main/crates/secrets/src/forge_vault.rs#L665

We hard code the namespace and trust_domain

Feature Description

Settings related to communication with vault should be configurable in the api runtime config

Describe your ideal solution

No response

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow NCX Infra Controller's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureFeature (deprecated - use issue type, but it's needed for reporting now)
    No fields configured for Enhancement.

    Projects

    Status

    Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions