chore(model,rpc): move conversion to/from RPC to rpc crate#1779
Draft
poroh wants to merge 1 commit into
Draft
Conversation
poroh
commented
May 18, 2026
| pub history: Vec<StateHistoryRecord>, | ||
| } | ||
|
|
||
| impl TryFrom<DpaInterfaceSnapshotPgJson> for DpaInterface { |
Contributor
Author
There was a problem hiding this comment.
Review note: this conversion was wrongly moved to RPC.
| Static, | ||
| } | ||
|
|
||
| impl From<AddressSelectionStrategy> for AllocationType { |
Contributor
Author
There was a problem hiding this comment.
Review note: this was wrongly moved to RPC.
| Err(_) => "".to_owned(), | ||
| }; | ||
| stdout_str = stdout_str + &message; | ||
| stdout_str += message.as_str(); |
Contributor
Author
There was a problem hiding this comment.
Review note: for some unknown reasons compiler started complain on inability to add &String to String.
| tracing::debug!("family_indicator is {0}", spec_version); | ||
|
|
||
| let vendor = vendor_1.clone() + &vendor_2; | ||
| let vendor = vendor_1.clone() + vendor_2.as_str(); |
Contributor
Author
There was a problem hiding this comment.
Review note: for some unknown reasons compiler started complain on inability to add &String to String.
poroh
force-pushed
the
rpc-conversion-in-rpc-crate
branch
from
9ab1437 to
59b9ca9
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
poroh
force-pushed
the
rpc-conversion-in-rpc-crate
branch
from
59b9ca9 to
7ade8ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move all conversion to RPC crate. Model dependency is compiled under "model" feature flag.
Handful of types required custom conversion trait (RpcTryFrom/RpcFrom) because these conversions are defined for external types (like
Option<rpc::Instance>).Dependency from DB to RPC is still in place, so, compilation speed up is not there yet.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes