fix(bluefield): make cert directory configurable to match agent code#1790
Merged
Merged
Conversation
The carbide/forge → NICo rename in PR NVIDIA#1532 updated the helm charts to mount certs at /opt/nico, but the Rust agent code (and bundled otel configs) still read certs from /opt/forge/forge_root.pem. The chart and the binary were pointing at different directories, breaking certificate discovery for nico-fmds, nico-dpu-agent, nico-dpu-otel-agent, and nico-otelcol. Adds helm-unittest coverage under each chart's tests/ directory verifying both the default (forge) and cleared (nico) render paths. Signed-off-by: Ian Anderson <ianderson@nvidia.com>
ianderson-nvidia
force-pushed
the
fix_bluefield_forge
branch
from
ec98b3c to
4891d02
Compare
wminckler
reviewed
May 19, 2026
|
|
||
| ### Cert directory on the host (also used as the container mountPath). | ||
| certsDir: /opt/forge | ||
|
|
Contributor
There was a problem hiding this comment.
don't you need rootCaFile here?
wminckler
approved these changes
May 19, 2026
abvarshney-nv
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The carbide/forge → NICo rename in PR #1532 updated the helm charts to mount certs at /opt/nico, but the Rust agent code (and bundled otel configs) still read certs from /opt/forge/forge_root.pem. The chart and the binary were pointing at different directories, breaking certificate discovery for nico-fmds, nico-dpu-agent, nico-dpu-otel-agent, and nico-otelcol.
Adds helm-unittest coverage under each chart's tests/ directory verifying both the default (forge) and cleared (nico) render paths.
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes