txn_held_across_await lint: Fire on holding a PoolConnection#1893
Open
kensimon wants to merge 1 commit into
Open
txn_held_across_await lint: Fire on holding a PoolConnection#1893kensimon wants to merge 1 commit into
kensimon wants to merge 1 commit into
Conversation
A PoolConnection may or may not correspond to an active connection to the database, but even if it doesn't, it consumes sqlx's pool limits. A change in NVIDIA#1884 should probably have fired this lint, so add support to detect it.
poroh
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A PoolConnection may or may not correspond to an active connection to the database, but even if it doesn't, it consumes sqlx's pool limits.
A change in #1884 should probably have fired this lint, so add support to detect it.
Type of Change
Breaking Changes
Testing
Additional Notes