Skip to content

ci(rest): disable main publish + fix duplicate SHA in image tag#1922

Merged
lachen-nv merged 1 commit into
NVIDIA:mainfrom
lachen-nv:chore/rest-disable-main-publish
May 25, 2026
Merged

ci(rest): disable main publish + fix duplicate SHA in image tag#1922
lachen-nv merged 1 commit into
NVIDIA:mainfrom
lachen-nv:chore/rest-disable-main-publish

Conversation

@lachen-nv
Copy link
Copy Markdown
Contributor

Summary

Temporarily disable REST publish on main/release/tags and fix the duplicate-SHA bug in REST image tags. Core publish is unchanged.

Why disable

Post-merge of #1800, main started pushing REST images to NGC with redundant SHA suffix:

nvcr.io/0837451325059433/carbide-dev/nico-rest-api:0.11.0-pr-3-g72855901-72855901
                                                                ^^^^^^^^^^^^^^^^^^
                                                                duplicated SHA

semantic_version from git describe --long already ends in -g<short_sha>, so appending -${short_sha} produced the duplicate.

Why fix in same PR

The tag fix is small and self-contained — shipping the disable and fix together means the follow-up PR is just removing the false toggles.

Changes

  • rest-ci.yml: push_enabled: false (was conditional)
  • rest-helm-workflows.yml: if: false on push-charts (was conditional)
  • rest-build-push-service.yml:
    • PRIMARY_TAG = semantic_version (main branch) — drop redundant -short_sha
    • ARTIFACT_VERSION = semantic_version — drop redundant -short_sha
    • latest tarball upload path now uses artifact_version (was hardcoded with duplicate)

Scope

  • REST docker push — disabled
  • REST helm push — disabled
  • Core CI publish — unchanged
  • Promotion workflow — unchanged

Follow-up

Once verified the fix produces clean tags on a non-publish run, open a follow-up to revert the two false toggles:

# rest-ci.yml
push_enabled: ${{ github.event_name != 'workflow_dispatch' && !contains(github.ref, 'pull-request/') }}

# rest-helm-workflows.yml
if: ${{ !cancelled() && github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' && needs.validate-charts.result == 'success' && !contains(github.ref, 'pull-request/') }}

Expected tag after fix + re-enable

nvcr.io/0837451325059433/carbide-dev/nico-rest-api:0.11.0-pr-3-g72855901
nvcr.io/0837451325059433/carbide-dev/nico-rest-api:latest

@lachen-nv lachen-nv requested a review from a team as a code owner May 25, 2026 05:33
@github-actions
Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-05-25 05:34:53 UTC | Commit: 7c1e4e0

Copy link
Copy Markdown
Contributor

@mmou-nv mmou-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions
Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
nico-flow 66 4 34 18 2 8
nico-nsm 82 2 28 43 9 0
nico-psm 67 4 35 18 2 8
nico-rest-api 100 6 53 30 3 8
nico-rest-cert-manager 65 4 34 18 1 8
nico-rest-db 66 4 34 18 2 8
nico-rest-site-agent 65 4 34 18 1 8
nico-rest-site-manager 65 4 34 18 1 8
nico-rest-workflow 67 4 35 18 2 8
TOTAL 643 36 321 199 23 64

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

@lachen-nv lachen-nv merged commit 32700d7 into NVIDIA:main May 25, 2026
89 checks passed
@lachen-nv lachen-nv deleted the chore/rest-disable-main-publish branch May 25, 2026 05:45
lachen-nv added a commit to lachen-nv/ncx-infra-controller-core that referenced this pull request May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants