ci(rest): disable main publish + fix duplicate SHA in image tag#1922
Merged
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-05-25 05:34:53 UTC | Commit: 7c1e4e0 |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
lachen-nv
added a commit
to lachen-nv/ncx-infra-controller-core
that referenced
this pull request
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily disable REST publish on main/release/tags and fix the duplicate-SHA bug in REST image tags. Core publish is unchanged.
Why disable
Post-merge of #1800, main started pushing REST images to NGC with redundant SHA suffix:
semantic_versionfromgit describe --longalready ends in-g<short_sha>, so appending-${short_sha}produced the duplicate.Why fix in same PR
The tag fix is small and self-contained — shipping the disable and fix together means the follow-up PR is just removing the
falsetoggles.Changes
rest-ci.yml:push_enabled: false(was conditional)rest-helm-workflows.yml:if: falseonpush-charts(was conditional)rest-build-push-service.yml:PRIMARY_TAG = semantic_version(main branch) — drop redundant-short_shaARTIFACT_VERSION = semantic_version— drop redundant-short_shalatesttarball upload path now usesartifact_version(was hardcoded with duplicate)Scope
Follow-up
Once verified the fix produces clean tags on a non-publish run, open a follow-up to revert the two
falsetoggles:Expected tag after fix + re-enable