fix: add retry logic in uefi_setup for hosts with existing BIOS password#39
Merged
Conversation
parmani-nv
force-pushed
the
fix/bmc_retry_setpassword
branch
from
68516ed to
a1203fa
Compare
wminckler
approved these changes
Jan 16, 2026
When setting the UEFI password on hosts during re-ingestion, the first attempt assumes no password is set (empty current password). This fails if the BMC already has a password set, causing hosts to get stuck in the UefiSetup state. This can happen when: - Force-delete failed to clear the password (network/BMC issues) - Host was force-deleted before UEFI clearing was implemented - Manual BIOS password was set outside of Forge - Previous ingestion was interrupted after password was set The fix adds retry logic: if the first attempt with empty password fails, retry using the site default password as the current password. This handles re-ingested hosts that still have the site password set on the BMC. The retry with change(site_pw, site_pw) is effectively a no-op that validates the password matches what Forge expects and allows ingestion to proceed. Fixes: NVBugs 5792728 Signed-off-by: Parham Armani <parmani@nvidia.com>
parmani-nv
force-pushed
the
fix/bmc_retry_setpassword
branch
from
a1203fa to
428721d
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When setting the UEFI password on hosts during re-ingestion, the first attempt assumes no password is set (empty current password). This fails if the BMC already has a password set, causing hosts to get stuck in the UefiSetup state.
This can happen when:
Change
The fix adds retry logic: if the first attempt with empty password fails, retry using the site default password as the current password. This handles re-ingested hosts that still have the site password set on the BMC.
The retry with change(site_pw, site_pw) is effectively a no-op that validates the password matches what Forge expects and allows ingestion to proceed.
Fix
NVBugs 5792728
https://nvbugspro.nvidia.com/bug/5792728
https://nvbugspro.nvidia.com/bug/5122539