Merged
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
cdesiniotis
approved these changes
Jun 17, 2024
|
|
||
| # Iterate over the commit messages and ignore the ones that start with "Merge" or "Bump" | ||
| git log --pretty=format:"%s" $REFERENCE..@ | grep -Ev "(^Merge )|(^Bump)" | sed 's/^\(.*\)/- \1\\n/g' | ||
| git log --pretty=format:"%s" $REFERENCE..@ | grep -Ev "(^Merge )|(^Bump)" | sed 's/^\(.*\)/- \1/g' |
Contributor
There was a problem hiding this comment.
This is my first time seeing this. Nice!
Member
Author
There was a problem hiding this comment.
It does generate a very VERBOSE changelog, but it's probably better to add better checks and commit messages than to manually generate those anyway.
elezar
commented
Jun 17, 2024
Comment on lines
+157
to
+160
| if [[ $release == *-rc.* ]]; then | ||
| echo "Skipping README update" | ||
| exit 0 | ||
| fi |
Member
Author
There was a problem hiding this comment.
@ArangoGutierrez here are the changes to not update the readme on rc releases.
elezar
commented
Jun 17, 2024
|
|
||
| ### Version v1.16.0-rc.1 | ||
|
|
||
| - Skip container updates if only CDI is selected |
Member
Author
There was a problem hiding this comment.
We definitely need to filter these a bit more strictly.
Collaborator
There was a problem hiding this comment.
is just a helper script, to filter them better we would need to be more strict with Commit naming so we can use regex filters, or have an LLM action as a helper for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.