Upgrade expected attention with support for more models#126
Merged
alessiodevoto merged 4 commits intomainfrom Aug 26, 2025
Merged
Upgrade expected attention with support for more models#126alessiodevoto merged 4 commits intomainfrom
alessiodevoto merged 4 commits intomainfrom
Conversation
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
maxjeblick
reviewed
Aug 26, 2025
Collaborator
maxjeblick
left a comment
There was a problem hiding this comment.
Thanks a lot for the changes!
Overall, it looks good. I left some code comments. Most are minor.
Do you think one can extract get_query_states function and resue it within the codebase?
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Right now expected attention does not support QK norm models (Gemma, Qwen). This PR:
To make sure the two methods are equivalent, I tested them with Llama 3.1-8B on Ruler 4096 with 0.5 compression, obtaining the same results with a delta < .5%, probably due to precision.
Also, I benchmarked the compression speed across 10 runs to make sure working in the query space does not slow down compression. Turns out it does not, here are the results:
Current implementation
New implementation
Checklist
make test)make style, on errors try fix withmake format)git commit -smypress_press.pyis in thepressesdirectoryMyPressis in__init__.pyREADME.mdis updated with a 1 liner about the new press in the Available presses sectiondefault_presseslist intests/default_presses.py