Skip to content

evaluation README.md command error and logging error #127#128

Merged
alessiodevoto merged 1 commit intoNVIDIA:mainfrom
wzp-0815:main
Aug 26, 2025
Merged

evaluation README.md command error and logging error #127#128
alessiodevoto merged 1 commit intoNVIDIA:mainfrom
wzp-0815:main

Conversation

@wzp-0815
Copy link
Copy Markdown
Contributor

PR description

Description of your PR. Fixes # (issue) (if applicable)

Checklist

  • Tests are working (make test)
  • Code is formatted correctly (make style, on errors try fix with make format)
  • Copyright header is included
  • All commits are signed-off using git commit -s
  • (new press) mypress_press.py is in the presses directory
  • (new press) MyPress is in __init__.py
  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section
  • (new press) New press is in the default_presses list in tests/default_presses.py
  • (new press) A docstring is provided that follows the same structure as the existing ones

Signed-off-by: laoman.wzp <laoman.wzp@antgroup.com>
@alessiodevoto
Copy link
Copy Markdown
Collaborator

Hi @wzp-0815 thanks for catching this! LGTM, will merge now !

@alessiodevoto alessiodevoto merged commit c44e85a into NVIDIA:main Aug 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants