Conversation
SimJeg
force-pushed
the
simon/update-decoding-notebook
branch
from
ef5009c to
cdb4257
Compare
maxjeblick
approved these changes
Nov 13, 2025
Collaborator
maxjeblick
left a comment
maxjeblick
left a comment
There was a problem hiding this comment.
LGTM thanks!
As discussed, let's update to 0.4
SimJeg
force-pushed
the
simon/update-decoding-notebook
branch
from
72eb02d to
883ea8d
Compare
Signed-off-by: SimJeg <sjegou@nvidia.com>
Signed-off-by: SimJeg <sjegou@nvidia.com>
SimJeg
force-pushed
the
simon/update-decoding-notebook
branch
from
883ea8d to
ad2bcb0
Compare
maxjeblick
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the notebook kvpress_decoding_aime25.ipynb to remove the displays of the cache size which are incorrect as the kvpress pipeline removes the tokens associated with the answer after decoding.
cc @YunSunny00