Skip to content

Clean evaluation#162

Merged
SimJeg merged 2 commits intomainfrom
simon/clean-evaluation
Nov 27, 2025
Merged

Clean evaluation#162
SimJeg merged 2 commits intomainfrom
simon/clean-evaluation

Conversation

@SimJeg
Copy link
Copy Markdown
Collaborator

@SimJeg SimJeg commented Nov 26, 2025

  • Cleaned README in evaluation
  • Fixed wikipedia notebook
  • Fixed CURPress import issue
  • Renamed get_query_states to get_prerope_query_states
  • Changed deprecated kwarg torch_dtype to dtype when calling the pipeline

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Nov 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg SimJeg force-pushed the simon/clean-evaluation branch from 493c458 to d06ba90 Compare November 26, 2025 15:34
@SimJeg
Copy link
Copy Markdown
Collaborator Author

SimJeg commented Nov 26, 2025

/ok to test d06ba90

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg SimJeg requested a review from maxjeblick November 27, 2025 07:47
Copy link
Copy Markdown
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SimJeg SimJeg merged commit dafafcb into main Nov 27, 2025
2 checks passed
@SimJeg SimJeg deleted the simon/clean-evaluation branch November 27, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants