Skip to content

Fix evaluation README uv sync command#188

Merged
SimJeg merged 1 commit intoNVIDIA:mainfrom
shpark1104:fixreadme
Feb 23, 2026
Merged

Fix evaluation README uv sync command#188
SimJeg merged 1 commit intoNVIDIA:mainfrom
shpark1104:fixreadme

Conversation

@shpark1104
Copy link
Copy Markdown
Contributor

PR description

  • Fixed uv sync --group eval(not working) to uv sync --extra eval (as in the root README)

Checklist

Before submitting a PR, please make sure:

  • Tests are working (make test)

  • Code is formatted correctly (make style, on errors try fix with make format)

  • Copyright header is included

  • All commits are signed-off using git commit -s

  • (new press) mypress_press.py is in the presses directory

  • (new press) MyPress is in __init__.py

  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section

  • (new press) New press is in the default_presses list in tests/default_presses.py

  • (new press) A docstring is provided that follows the same structure as the existing ones

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Feb 21, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@SimJeg
Copy link
Copy Markdown
Collaborator

SimJeg commented Feb 23, 2026

Hi @shpark1104, thanks for the PR. Could you sign off your commit so that I can merge ?

From DCO:

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin fixreadme

@SimJeg SimJeg self-assigned this Feb 23, 2026
Signed-off-by: shpark1104 <shpark061104@gmail.com>
@shpark1104
Copy link
Copy Markdown
Contributor Author

Added sign-off and pushed the commit. Thanks!

@SimJeg SimJeg merged commit 393070e into NVIDIA:main Feb 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants