Fix make test silently passing when pytest fails#208
Merged
alessiodevoto merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Signed-off-by: alessiodevoto <adevoto@nvidia.com>
Collaborator
Author
|
/ok to test 994d51a |
Collaborator
Author
|
Ok this is working, tests failed (as they should) due the import error. |
maxjeblick
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
make testsilently passing when pytest failsThis PR fixes #207 by adding
-o pipefailto the shell, that makes the pipe return pytest's exit code directly, regardless of the failure mode.