Skip to content

Remove unrelated dependencies#74

Merged
SimJeg merged 4 commits intoNVIDIA:mainfrom
fanqiNO1:fix_dep
May 6, 2025
Merged

Remove unrelated dependencies#74
SimJeg merged 4 commits intoNVIDIA:mainfrom
fanqiNO1:fix_dep

Conversation

@fanqiNO1
Copy link
Copy Markdown
Contributor

@fanqiNO1 fanqiNO1 commented May 6, 2025

PR description

Fix #73

Checklist

  • Tests are working (make test)
  • Code is formatted correctly (make style, on errors try fix with make format)
  • Copyright header is included
  • All commits are signed-off using git commit -s
  • (new press) mypress_press.py is in the presses directory
  • (new press) MyPress is in __init__.py
  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section
  • (new press) new press is in the default_presses list in tests/default_presses.py

Tests

image

fanqiNO1 added 2 commits May 6, 2025 20:22
Signed-off-by: fanqiNO1 <1848839264@qq.com>
Signed-off-by: fanqiNO1 <1848839264@qq.com>
@SimJeg
Copy link
Copy Markdown
Collaborator

SimJeg commented May 6, 2025

Hi ! Having lighter dependencies make a lot of sense for the pip package. Could you also update the README installation section with a single line explaining how to install them ? (maybe poetry install --with all ? please check)

@fanqiNO1
Copy link
Copy Markdown
Contributor Author

fanqiNO1 commented May 6, 2025

poetry install --with all

Actually, poetry install will install the dev dependencies and others under tool.poetry.group.all.dependencies. But I am new to poetry. 😢 By the way, I change tool.poetry.group.all.dependencies to tool.poetry.group.examples.dependencies because all sounds weird.

Based on the https://python-poetry.org/docs/managing-dependencies#optional-groups, maybe we need

[tool.poetry.group.dev]
optional = true

[tool.poetry.group.examples]
optional = true

Signed-off-by: fanqiNO1 <1848839264@qq.com>
Signed-off-by: fanqiNO1 <1848839264@qq.com>
@SimJeg
Copy link
Copy Markdown
Collaborator

SimJeg commented May 6, 2025

@fanqiNO1 thanks for the udpate, have you checked poetry install --with devworks as expected ?

@fanqiNO1
Copy link
Copy Markdown
Contributor Author

fanqiNO1 commented May 6, 2025

@fanqiNO1 thanks for the udpate, have you checked poetry install --with devworks as expected ?

I will check it now. Wait for a moment.

@fanqiNO1
Copy link
Copy Markdown
Contributor Author

fanqiNO1 commented May 6, 2025

Run poetry install:

image

Run poetry install --with dev after running poetry install:

image

It works well.

@SimJeg
Copy link
Copy Markdown
Collaborator

SimJeg commented May 6, 2025

LGMT, thanks for your contribution !

@SimJeg SimJeg merged commit 3dbf8f4 into NVIDIA:main May 6, 2025
3 checks passed
@fanqiNO1 fanqiNO1 deleted the fix_dep branch May 6, 2025 15:37
maxjeblick pushed a commit that referenced this pull request Jun 6, 2025
Signed-off-by: Max Jeblick <maximilianjeblick@gmail.com>
maxjeblick pushed a commit that referenced this pull request Aug 12, 2025
Signed-off-by: Max Jeblick <maximilianjeblick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhance] Remove unrelated dependencies

2 participants