fix: don't capture parent tracing span in http requests#30
Merged
poroh merged 1 commit intoNVIDIA:mainfrom Jan 30, 2026
Merged
Conversation
Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
Matthias247
approved these changes
Jan 30, 2026
Matthias247
left a comment
Matthias247
left a comment
There was a problem hiding this comment.
Thanks! Might need to do something similar with other HTTP interactions, e.g. the NMX-M client.
10 tasks
krish-nvidia
added a commit
to NVIDIA/bare-metal-manager-core
that referenced
this pull request
Jan 30, 2026
## Description This PR brings in the following changes from libredfish `v0.39.1`: - fix: don't capture parent tracing span in http requests by @poroh in NVIDIA/libredfish#30 - feat: further support for newer iDRAC BIOS/UEFI password configuration by @krish-nvidia in NVIDIA/libredfish#31 ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [x] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue of capturing parent tracing span by long-living HTTP threads in hyper.
Here are details:
hyper-util's TokioExecutor spawns background tasks using .in_current_span() when the tracing feature is enabled.
tracing feature is not enabled by libredfish directly or through reqwest but may be enabled by feature unification that comes with another dependencies.