Configure Dell BIOS task IDs in machine setup#54
Merged
kdhulipala-wq merged 8 commits intoNVIDIA:mainfrom Apr 13, 2026
Merged
Conversation
krish-nvidia
previously approved these changes
Apr 6, 2026
krish-nvidia
left a comment
krish-nvidia
left a comment
There was a problem hiding this comment.
Looks good after you fix the merge conflicts, remove the debug log lines, and sign your commits.
Signed-off-by: Krishna Dhulipala <kdhulipala@nvidia.com>
Signed-off-by: Krishna Dhulipala <kdhulipala@nvidia.com>
Signed-off-by: Krishna Dhulipala <kdhulipala@nvidia.com>
Signed-off-by: Krishna Dhulipala <kdhulipala@nvidia.com>
Signed-off-by: Krishna Dhulipala <kdhulipala@nvidia.com>
Signed-off-by: Krishna Dhulipala <kdhulipala@nvidia.com>
…VIDIA#47) machine_setup() gains an oem_manager_profiles parameter (same structure as bios_profiles) allowing callers to supply vendor/model/profile-keyed manager attribute maps without hardcoding them in library code. For Dell, these attributes are merged into the existing machine_setup_oem PATCH payload alongside the fixed iDRAC settings (HostHeaderCheck, IPMILan, OS-BMC). All other vendors accept the parameter as a no-op. The previously added disable_psu_hot_spare() trait method is removed; PSU Hot Spare configuration is now expressed as an oem_manager_profiles entry. Signed-off-by: Martin Raumann <mraumann@nvidia.com>
Signed-off-by: Krishna Dhulipala <kdhulipala@nvidia.com>
krish-nvidia
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I didn't know I had to add signatures to my commits, and I think this will prevent me from merging this PR once it is approved. After approval I will duplicate the PR with a single signed commit to fix this
Changes to ensure Dell BIOS configuration jobs complete before configuring boot order. On Dell iDRACs, PATCHing BIOS attributes returns an asynchronous job ID. Previously, we didn't track these jobIDs, which have the potential to lead to boot order configuration racings ahead of pending BIOS changes. Below is a short summary of my changes: