fix: enable network boot option for lenovos if disabled#55
Merged
krish-nvidia merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
…etup Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>
zanezhuNVIDIA
approved these changes
Mar 20, 2026
10 tasks
krish-nvidia
added a commit
to NVIDIA/ncx-infra-controller-core
that referenced
this pull request
Mar 31, 2026
## Description This PR bumps libredfish to `v0.43.5` which brings in the following change: - fix: enable network boot option for lenovos if disabled by @krish-nvidia in NVIDIA/libredfish#55 ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [x] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some Lenovo hosts,
Networkis not present in the standard redfish boot options, causingboot_first(Boot::Pxe)to fail withMissingBootOption. When this happens, the network boot options list is empty, which also preventsset_boot_order_dpu_firstfrom finding the DPU.This adds a fallback in
machine_setup: ifboot_firstfails becauseNetworkis missing, we setNetworkfirst via the OEM Lenovo general boot order atBootOrder.BootOrder. If that OEM path returns 404 (newer firmware), we skip gracefully.