Skip to content

fix: stop deriving Debug for Endpoint#59

Merged
poroh merged 1 commit intoNVIDIA:mainfrom
poroh:fix-remove-debug-for-endpoint
Apr 10, 2026
Merged

fix: stop deriving Debug for Endpoint#59
poroh merged 1 commit intoNVIDIA:mainfrom
poroh:fix-remove-debug-for-endpoint

Conversation

@poroh
Copy link
Copy Markdown

@poroh poroh commented Apr 10, 2026

Endpoint contains BMC credentials, including password, so deriving Debug makes it easier to accidentally expose secrets in logs or error output.

Remove the Debug derive from Endpoint to avoid accidental credential leakage.

Endpoint contains BMC credentials, including password, so deriving
Debug makes it easier to accidentally expose secrets in logs or error
output.

Remove the Debug derive from Endpoint to avoid accidental credential
leakage.

Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
@krish-nvidia
Copy link
Copy Markdown

krish-nvidia commented Apr 10, 2026

Can you fix this one too in crates/libnmxm/src/lib.rs (nvm, wrong repo...)

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct Endpoint {
    pub host: String,
    pub username: Option<String>,
    pub password: Option<String>,
}

@poroh poroh merged commit 4a5f5fd into NVIDIA:main Apr 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants