Skip to content

fix: add custom deserializer for PSU's power state attribute to handle both string and boolean values.#62

Merged
spydaNVIDIA merged 2 commits intomainfrom
fix/pyda-psu
Apr 12, 2026
Merged

fix: add custom deserializer for PSU's power state attribute to handle both string and boolean values.#62
spydaNVIDIA merged 2 commits intomainfrom
fix/pyda-psu

Conversation

@spydaNVIDIA
Copy link
Copy Markdown

@spydaNVIDIA spydaNVIDIA commented Apr 12, 2026

GB200s report the PSU power state as a string: "On"/"Off"
Liteon PMCs report the PSU power state as a boolean: true/false

Querying a powershelf before the changes:

spyda@control72-cno1-cp1-jhb01:~$ ./carbide-admin-cli redfish --address 7.243.170.140 --username root --password 'password' --vendor lite-on-power-shelf get-power-state

Off

Querying a powershelf after the changes:

spyda@control72-cno1-cp1-jhb01:~$ ./carbide-admin-cli redfish --address 7.243.170.140 --username root --password 'password' --vendor lite-on-power-shelf get-power-state

On

@spydaNVIDIA spydaNVIDIA requested review from chet and kunzhao-nv April 12, 2026 21:24
chet
chet previously approved these changes Apr 12, 2026
…te of the ComputerSystem struct from aggregating the power states of the PSUs
@spydaNVIDIA spydaNVIDIA merged commit a2f873e into main Apr 12, 2026
2 checks passed
@yoks
Copy link
Copy Markdown

yoks commented Apr 13, 2026

Why try to read not in spec property for PSU? PowerState is present in:

  • Chassis
  • System
  • Circuit
  • Outlet
  • Switch

PowerSupply does not have PowerState. This sounds like something super specific and brittle (as it relly not on spec fields).

@spydaNVIDIA
Copy link
Copy Markdown
Author

Why try to read not in spec property for PSU? PowerState is present in:

  • Chassis
  • System
  • Circuit
  • Outlet
  • Switch

PowerSupply does not have PowerState. This sounds like something super specific and brittle (as it relly not on spec fields).

The PowerState being reported via Chassis and System information is not accurate for the Liteon Powershelves. I found that the only reliable source for the power state of the powershelf came from querying each of the PSU's power states as reported by its power supply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants