fix: add custom deserializer for PSU's power state attribute to handle both string and boolean values.#62
Merged
spydaNVIDIA merged 2 commits intomainfrom Apr 12, 2026
Merged
Conversation
…e both string and boolean values.
chet
previously approved these changes
Apr 12, 2026
…te of the ComputerSystem struct from aggregating the power states of the PSUs
chet
approved these changes
Apr 12, 2026
|
Why try to read not in spec property for PSU? PowerState is present in:
PowerSupply does not have PowerState. This sounds like something super specific and brittle (as it relly not on spec fields). |
Author
The PowerState being reported via Chassis and System information is not accurate for the Liteon Powershelves. I found that the only reliable source for the power state of the powershelf came from querying each of the PSU's power states as reported by its power supply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GB200s report the PSU power state as a string: "On"/"Off"
Liteon PMCs report the PSU power state as a boolean: true/false
Querying a powershelf before the changes:
Querying a powershelf after the changes: