Skip to content

feat(lpu): track optional ComputerSystem part_number#98

Merged
poroh merged 1 commit into
NVIDIA:mainfrom
iExalt:clliaw/track-part-number
Jun 26, 2026
Merged

feat(lpu): track optional ComputerSystem part_number#98
poroh merged 1 commit into
NVIDIA:mainfrom
iExalt:clliaw/track-part-number

Conversation

@iExalt

@iExalt iExalt commented Jun 25, 2026

Copy link
Copy Markdown

Executive Summary

  • ComputerSystem.part_number was commented out in ad1b4d4 because Lenovo systems reported null for this field.

Summary

Expose ComputerSystem.part_number as an optional field so callers can read part numbers while correctly handling Lenovo systems that return null.

Root cause

The property had been commented out because the original required String type could not deserialize Lenovo's null value.

Validation

  • mise exec -- cargo test model::system
  • mise exec -- cargo fmt --check
  • git diff --check

@iExalt iExalt marked this pull request as ready for review June 25, 2026 19:54
@poroh poroh merged commit 6277ffb into NVIDIA:main Jun 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants