Merged
Conversation
azrael417
force-pushed
the
tkurth/compile-save-restore-fixes
branch
from
c673e9d to
531c81e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.compile prepends more prefixes to parameter names causing the current logic to fail loading a checkpoint into a compiled model which was written by an uncompiled model and vice versa. Also, torch.compile breaks some of the logic we had in place for dealing with data parallel prefixes. This MR fixes all those issues by detecting all combinations of those prefixes and making sure to strip them for saving and prepend them for loading.