Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (22)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughBumps Go toolchain from 1.26.2 → 1.26.3 across CI workflows, Makefiles, and Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
operator/api/v1alpha1/skyhook_webhook.go (1)
56-56: 🧹 Nitpick | 🔵 Trivial | 💤 Low valueConsider removing scaffolding TODO comment.
This is a kubebuilder scaffolding comment that's no longer relevant since the webhook has been implemented.
🧹 Suggested cleanup
-// TODO(user): EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN!🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@operator/api/v1alpha1/skyhook_webhook.go` at line 56, Remove the scaffolding TODO comment line "TODO(user): EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN!" from skyhook_webhook.go now that the webhook is implemented; simply delete that comment so the file no longer contains the outdated kubebuilder scaffolding note.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@operator/vendor/github.com/emicklei/go-restful/v3/custom_verb.go`:
- Around line 13-24: Replace the unsynchronized boolean flag
customVerbCacheEnabled with an atomic.Bool to avoid data races: change its
declaration to an atomic.Bool, update SetCustomVerbCacheEnabled to call
.Store(enabled), and update all reads in isMatchCustomVerb (and any other
readers) to use .Load() instead of direct reads; ensure imports include
sync/atomic (or the atomic.Bool type) and update references to the symbol
customVerbCacheEnabled accordingly.
In `@operator/vendor/github.com/prometheus/common/expfmt/openmetrics_create.go`:
- Around line 338-343: The code currently checks float histogram support by
testing b.GetCumulativeCountFloat() > 0 and similarly for GetSampleCountFloat(),
but these getters return 0 when the protobuf field is unset or explicitly zero;
instead detect whether the underlying float fields are present (non-nil) or
non-finite and reject any explicit float histogram fields regardless of value.
Update the checks in openmetrics_create.go around the blocks referencing
GetCumulativeCountFloat and GetSampleCountFloat (also the similar block at the
other occurrence) to inspect the protobuf presence (e.g., the pointer/has-field)
or use the generated Has* accessor before emitting, and return the
fmt.Errorf("OpenMetrics v1.0 does not support float histogram %s %s",
compliantName, metric) when the float field is present or non-finite.
In `@operator/vendor/github.com/prometheus/common/expfmt/text_parse.go`:
- Around line 573-581: The float branches for histogram counts/buckets (e.g.,
assignments to p.currentMetric.Histogram.SampleCountFloat and
CumulativeCountFloat) currently only reject negative values but allow NaN/Inf;
update parsing to reject non-finite values as well by checking for
math.IsNaN(value) || math.IsInf(value, 0) (or an equivalent “is finite” test)
and call p.parseError with a descriptive message (similar to the existing
negative-case message using p.currentMF.GetName()) and return nil when
non-finite or negative; apply the same change to both the SampleCountFloat
handling and the cumulative bucket count branch so neither NaN nor ±Inf can be
stored.
---
Outside diff comments:
In `@operator/api/v1alpha1/skyhook_webhook.go`:
- Line 56: Remove the scaffolding TODO comment line "TODO(user): EDIT THIS FILE!
THIS IS SCAFFOLDING FOR YOU TO OWN!" from skyhook_webhook.go now that the
webhook is implemented; simply delete that comment so the file no longer
contains the outdated kubebuilder scaffolding note.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 1fb7bcf7-5979-4584-b9c3-3e7e72aaf40e
⛔ Files ignored due to path filters (13)
operator/go.sumis excluded by!**/*.sumoperator/vendor/google.golang.org/protobuf/types/descriptorpb/descriptor.pb.gois excluded by!**/*.pb.gooperator/vendor/google.golang.org/protobuf/types/known/timestamppb/timestamp.pb.gois excluded by!**/*.pb.gooperator/vendor/k8s.io/api/admission/v1/generated.protomessage.pb.gois excluded by!**/*.pb.gooperator/vendor/k8s.io/api/admissionregistration/v1/generated.pb.gois excluded by!**/*.pb.gooperator/vendor/k8s.io/api/admissionregistration/v1/generated.protomessage.pb.gois excluded by!**/*.pb.gooperator/vendor/k8s.io/api/admissionregistration/v1/types_swagger_doc_generated.gois excluded by!**/*_generated.gooperator/vendor/k8s.io/api/admissionregistration/v1alpha1/generated.protomessage.pb.gois excluded by!**/*.pb.gooperator/vendor/k8s.io/api/admissionregistration/v1alpha1/types_swagger_doc_generated.gois excluded by!**/*_generated.gooperator/vendor/k8s.io/api/admissionregistration/v1beta1/generated.protomessage.pb.gois excluded by!**/*.pb.gooperator/vendor/k8s.io/api/admissionregistration/v1beta1/types_swagger_doc_generated.gois excluded by!**/*_generated.gooperator/vendor/k8s.io/api/apidiscovery/v2/generated.protomessage.pb.gois excluded by!**/*.pb.gooperator/vendor/k8s.io/api/apidiscovery/v2beta1/generated.protomessage.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (287)
.claude/CLAUDE.md.github/workflows/agent-ci.yaml.github/workflows/cli-release.yaml.github/workflows/operator-ci.yaml.gitlab-ci.ymloperator/Makefileoperator/README.mdoperator/api/v1alpha1/deployment_policy_webhook.gooperator/api/v1alpha1/groupversion_info.gooperator/api/v1alpha1/skyhook_webhook.gooperator/go.modoperator/vendor/github.com/emicklei/go-restful/v3/.travis.ymloperator/vendor/github.com/emicklei/go-restful/v3/CHANGES.mdoperator/vendor/github.com/emicklei/go-restful/v3/README.mdoperator/vendor/github.com/emicklei/go-restful/v3/curly.gooperator/vendor/github.com/emicklei/go-restful/v3/custom_verb.gooperator/vendor/github.com/emicklei/go-restful/v3/doc.gooperator/vendor/github.com/gogo/protobuf/AUTHORSoperator/vendor/github.com/gogo/protobuf/CONTRIBUTORSoperator/vendor/github.com/gogo/protobuf/proto/Makefileoperator/vendor/github.com/gogo/protobuf/proto/clone.gooperator/vendor/github.com/gogo/protobuf/proto/custom_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/decode.gooperator/vendor/github.com/gogo/protobuf/proto/deprecated.gooperator/vendor/github.com/gogo/protobuf/proto/discard.gooperator/vendor/github.com/gogo/protobuf/proto/duration.gooperator/vendor/github.com/gogo/protobuf/proto/duration_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/encode.gooperator/vendor/github.com/gogo/protobuf/proto/encode_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/equal.gooperator/vendor/github.com/gogo/protobuf/proto/extensions.gooperator/vendor/github.com/gogo/protobuf/proto/extensions_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/lib.gooperator/vendor/github.com/gogo/protobuf/proto/lib_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/message_set.gooperator/vendor/github.com/gogo/protobuf/proto/pointer_reflect.gooperator/vendor/github.com/gogo/protobuf/proto/pointer_reflect_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/pointer_unsafe.gooperator/vendor/github.com/gogo/protobuf/proto/pointer_unsafe_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/properties.gooperator/vendor/github.com/gogo/protobuf/proto/properties_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/skip_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/table_marshal.gooperator/vendor/github.com/gogo/protobuf/proto/table_marshal_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/table_merge.gooperator/vendor/github.com/gogo/protobuf/proto/table_unmarshal.gooperator/vendor/github.com/gogo/protobuf/proto/table_unmarshal_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/text.gooperator/vendor/github.com/gogo/protobuf/proto/text_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/text_parser.gooperator/vendor/github.com/gogo/protobuf/proto/timestamp.gooperator/vendor/github.com/gogo/protobuf/proto/timestamp_gogo.gooperator/vendor/github.com/gogo/protobuf/proto/wrappers.gooperator/vendor/github.com/gogo/protobuf/proto/wrappers_gogo.gooperator/vendor/github.com/gogo/protobuf/sortkeys/sortkeys.gooperator/vendor/github.com/google/pprof/profile/merge.gooperator/vendor/github.com/google/pprof/profile/profile.gooperator/vendor/github.com/google/pprof/profile/proto.gooperator/vendor/github.com/google/pprof/profile/prune.gooperator/vendor/github.com/gregjones/httpcache/.travis.ymloperator/vendor/github.com/gregjones/httpcache/README.mdoperator/vendor/github.com/onsi/ginkgo/v2/CHANGELOG.mdoperator/vendor/github.com/onsi/ginkgo/v2/README.mdoperator/vendor/github.com/onsi/ginkgo/v2/core_dsl.gooperator/vendor/github.com/onsi/ginkgo/v2/decorator_dsl.gooperator/vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.gooperator/vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/run.gooperator/vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.gooperator/vendor/github.com/onsi/ginkgo/v2/internal/focus.gooperator/vendor/github.com/onsi/ginkgo/v2/internal/group.gooperator/vendor/github.com/onsi/ginkgo/v2/internal/node.gooperator/vendor/github.com/onsi/ginkgo/v2/internal/reporters/gojson.gooperator/vendor/github.com/onsi/ginkgo/v2/internal/suite.gooperator/vendor/github.com/onsi/ginkgo/v2/internal/testingtproxy/testing_t_proxy.gooperator/vendor/github.com/onsi/ginkgo/v2/reporters/default_reporter.gooperator/vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.gooperator/vendor/github.com/onsi/ginkgo/v2/reporters/teamcity_report.gooperator/vendor/github.com/onsi/ginkgo/v2/types/errors.gooperator/vendor/github.com/onsi/ginkgo/v2/types/semver_filter.gooperator/vendor/github.com/onsi/ginkgo/v2/types/types.gooperator/vendor/github.com/onsi/ginkgo/v2/types/version.gooperator/vendor/github.com/onsi/gomega/CHANGELOG.mdoperator/vendor/github.com/onsi/gomega/format/format.gooperator/vendor/github.com/onsi/gomega/gomega_dsl.gooperator/vendor/github.com/onsi/gomega/matchers.gooperator/vendor/github.com/onsi/gomega/matchers/have_key_matcher.gooperator/vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.gooperator/vendor/github.com/onsi/gomega/matchers/match_error_strictly_matcher.gooperator/vendor/github.com/onsi/gomega/matchers/support/goraph/edge/edge.gooperator/vendor/github.com/prometheus/common/expfmt/decode.gooperator/vendor/github.com/prometheus/common/expfmt/expfmt.gooperator/vendor/github.com/prometheus/common/expfmt/fuzz.gooperator/vendor/github.com/prometheus/common/expfmt/openmetrics_create.gooperator/vendor/github.com/prometheus/common/expfmt/text_create.gooperator/vendor/github.com/prometheus/common/expfmt/text_parse.gooperator/vendor/github.com/prometheus/procfs/.golangci.ymloperator/vendor/github.com/prometheus/procfs/Makefileoperator/vendor/github.com/prometheus/procfs/Makefile.commonoperator/vendor/github.com/prometheus/procfs/arp.gooperator/vendor/github.com/prometheus/procfs/buddyinfo.gooperator/vendor/github.com/prometheus/procfs/cmdline.gooperator/vendor/github.com/prometheus/procfs/cpuinfo.gooperator/vendor/github.com/prometheus/procfs/cpuinfo_armx.gooperator/vendor/github.com/prometheus/procfs/cpuinfo_loong64.gooperator/vendor/github.com/prometheus/procfs/cpuinfo_mipsx.gooperator/vendor/github.com/prometheus/procfs/cpuinfo_others.gooperator/vendor/github.com/prometheus/procfs/cpuinfo_ppcx.gooperator/vendor/github.com/prometheus/procfs/cpuinfo_riscvx.gooperator/vendor/github.com/prometheus/procfs/cpuinfo_s390x.gooperator/vendor/github.com/prometheus/procfs/cpuinfo_x86.gooperator/vendor/github.com/prometheus/procfs/crypto.gooperator/vendor/github.com/prometheus/procfs/doc.gooperator/vendor/github.com/prometheus/procfs/fs.gooperator/vendor/github.com/prometheus/procfs/fs_statfs_notype.gooperator/vendor/github.com/prometheus/procfs/fs_statfs_type.gooperator/vendor/github.com/prometheus/procfs/fscache.gooperator/vendor/github.com/prometheus/procfs/internal/fs/fs.gooperator/vendor/github.com/prometheus/procfs/internal/util/parse.gooperator/vendor/github.com/prometheus/procfs/internal/util/readfile.gooperator/vendor/github.com/prometheus/procfs/internal/util/sysreadfile.gooperator/vendor/github.com/prometheus/procfs/internal/util/sysreadfile_compat.gooperator/vendor/github.com/prometheus/procfs/internal/util/valueparser.gooperator/vendor/github.com/prometheus/procfs/ipvs.gooperator/vendor/github.com/prometheus/procfs/kernel_hung.gooperator/vendor/github.com/prometheus/procfs/kernel_random.gooperator/vendor/github.com/prometheus/procfs/loadavg.gooperator/vendor/github.com/prometheus/procfs/mdstat.gooperator/vendor/github.com/prometheus/procfs/meminfo.gooperator/vendor/github.com/prometheus/procfs/mountinfo.gooperator/vendor/github.com/prometheus/procfs/mountstats.gooperator/vendor/github.com/prometheus/procfs/net_conntrackstat.gooperator/vendor/github.com/prometheus/procfs/net_dev.gooperator/vendor/github.com/prometheus/procfs/net_dev_snmp6.gooperator/vendor/github.com/prometheus/procfs/net_ip_socket.gooperator/vendor/github.com/prometheus/procfs/net_protocols.gooperator/vendor/github.com/prometheus/procfs/net_route.gooperator/vendor/github.com/prometheus/procfs/net_sockstat.gooperator/vendor/github.com/prometheus/procfs/net_softnet.gooperator/vendor/github.com/prometheus/procfs/net_tcp.gooperator/vendor/github.com/prometheus/procfs/net_tls_stat.gooperator/vendor/github.com/prometheus/procfs/net_udp.gooperator/vendor/github.com/prometheus/procfs/net_unix.gooperator/vendor/github.com/prometheus/procfs/net_wireless.gooperator/vendor/github.com/prometheus/procfs/net_xfrm.gooperator/vendor/github.com/prometheus/procfs/netstat.gooperator/vendor/github.com/prometheus/procfs/nfnetlink_queue.gooperator/vendor/github.com/prometheus/procfs/proc.gooperator/vendor/github.com/prometheus/procfs/proc_cgroup.gooperator/vendor/github.com/prometheus/procfs/proc_cgroups.gooperator/vendor/github.com/prometheus/procfs/proc_environ.gooperator/vendor/github.com/prometheus/procfs/proc_fdinfo.gooperator/vendor/github.com/prometheus/procfs/proc_interrupts.gooperator/vendor/github.com/prometheus/procfs/proc_io.gooperator/vendor/github.com/prometheus/procfs/proc_limits.gooperator/vendor/github.com/prometheus/procfs/proc_maps.gooperator/vendor/github.com/prometheus/procfs/proc_netstat.gooperator/vendor/github.com/prometheus/procfs/proc_ns.gooperator/vendor/github.com/prometheus/procfs/proc_psi.gooperator/vendor/github.com/prometheus/procfs/proc_smaps.gooperator/vendor/github.com/prometheus/procfs/proc_snmp.gooperator/vendor/github.com/prometheus/procfs/proc_snmp6.gooperator/vendor/github.com/prometheus/procfs/proc_stat.gooperator/vendor/github.com/prometheus/procfs/proc_statm.gooperator/vendor/github.com/prometheus/procfs/proc_status.gooperator/vendor/github.com/prometheus/procfs/proc_sys.gooperator/vendor/github.com/prometheus/procfs/schedstat.gooperator/vendor/github.com/prometheus/procfs/slab.gooperator/vendor/github.com/prometheus/procfs/softirqs.gooperator/vendor/github.com/prometheus/procfs/stat.gooperator/vendor/github.com/prometheus/procfs/swaps.gooperator/vendor/github.com/prometheus/procfs/thread.gooperator/vendor/github.com/prometheus/procfs/vm.gooperator/vendor/github.com/prometheus/procfs/zoneinfo.gooperator/vendor/github.com/spf13/cobra/.golangci.ymloperator/vendor/github.com/spf13/cobra/command.gooperator/vendor/go.uber.org/zap/.golangci.ymloperator/vendor/go.uber.org/zap/CHANGELOG.mdoperator/vendor/go.uber.org/zap/CODE_OF_CONDUCT.mdoperator/vendor/go.uber.org/zap/LICENSEoperator/vendor/go.uber.org/zap/Makefileoperator/vendor/go.uber.org/zap/field.gooperator/vendor/go.uber.org/zap/http_handler.gooperator/vendor/go.uber.org/zap/logger.gooperator/vendor/go.uber.org/zap/options.gooperator/vendor/go.uber.org/zap/sink.gooperator/vendor/go.uber.org/zap/zapcore/buffered_write_syncer.gooperator/vendor/go.uber.org/zap/zapcore/console_encoder.gooperator/vendor/go.uber.org/zap/zapcore/entry.gooperator/vendor/go.uber.org/zap/zapcore/lazy_with.gooperator/vendor/go.uber.org/zap/zapcore/level.gooperator/vendor/golang.org/x/mod/semver/semver.gooperator/vendor/golang.org/x/net/http2/transport.gooperator/vendor/golang.org/x/net/http2/writesched_priority_rfc9218.gooperator/vendor/golang.org/x/oauth2/deviceauth.gooperator/vendor/golang.org/x/oauth2/oauth2.gooperator/vendor/golang.org/x/oauth2/pkce.gooperator/vendor/golang.org/x/oauth2/token.gooperator/vendor/golang.org/x/oauth2/transport.gooperator/vendor/golang.org/x/sync/errgroup/errgroup.gooperator/vendor/golang.org/x/sys/unix/mkerrors.shoperator/vendor/golang.org/x/sys/unix/zerrors_linux.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_386.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_arm.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_mips.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gooperator/vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gooperator/vendor/golang.org/x/sys/unix/ztypes_netbsd_arm.gooperator/vendor/golang.org/x/term/terminal.gooperator/vendor/golang.org/x/text/encoding/japanese/eucjp.gooperator/vendor/golang.org/x/text/encoding/japanese/iso2022jp.gooperator/vendor/golang.org/x/text/encoding/japanese/shiftjis.gooperator/vendor/golang.org/x/text/encoding/korean/euckr.gooperator/vendor/golang.org/x/text/encoding/simplifiedchinese/gbk.gooperator/vendor/golang.org/x/text/encoding/simplifiedchinese/hzgb2312.gooperator/vendor/golang.org/x/text/encoding/traditionalchinese/big5.gooperator/vendor/golang.org/x/text/encoding/unicode/unicode.gooperator/vendor/golang.org/x/time/rate/rate.gooperator/vendor/golang.org/x/time/rate/sometimes.gooperator/vendor/golang.org/x/tools/go/ast/inspector/cursor.gooperator/vendor/golang.org/x/tools/go/packages/packages.gooperator/vendor/golang.org/x/tools/go/packages/visit.gooperator/vendor/golang.org/x/tools/go/types/objectpath/objectpath.gooperator/vendor/golang.org/x/tools/go/types/typeutil/callee.gooperator/vendor/golang.org/x/tools/go/types/typeutil/map.gooperator/vendor/golang.org/x/tools/internal/event/core/export.gooperator/vendor/golang.org/x/tools/internal/event/label/label.gooperator/vendor/golang.org/x/tools/internal/gcimporter/bimport.gooperator/vendor/golang.org/x/tools/internal/gcimporter/iexport.gooperator/vendor/golang.org/x/tools/internal/gcimporter/iimport.gooperator/vendor/golang.org/x/tools/internal/stdlib/deps.gooperator/vendor/golang.org/x/tools/internal/stdlib/import.gooperator/vendor/golang.org/x/tools/internal/stdlib/manifest.gooperator/vendor/golang.org/x/tools/internal/stdlib/stdlib.gooperator/vendor/golang.org/x/tools/internal/typeparams/normalize.gooperator/vendor/golang.org/x/tools/internal/typesinternal/classify_call.gooperator/vendor/golang.org/x/tools/internal/typesinternal/element.gooperator/vendor/golang.org/x/tools/internal/typesinternal/fx.gooperator/vendor/golang.org/x/tools/internal/typesinternal/isnamed.gooperator/vendor/golang.org/x/tools/internal/typesinternal/qualifier.gooperator/vendor/golang.org/x/tools/internal/typesinternal/types.gooperator/vendor/golang.org/x/tools/internal/typesinternal/varkind.gooperator/vendor/golang.org/x/tools/internal/typesinternal/varkind_go124.gooperator/vendor/golang.org/x/tools/internal/typesinternal/zerovalue.gooperator/vendor/golang.org/x/tools/internal/versions/features.gooperator/vendor/google.golang.org/protobuf/encoding/protodelim/protodelim.gooperator/vendor/google.golang.org/protobuf/encoding/prototext/decode.gooperator/vendor/google.golang.org/protobuf/internal/descfmt/stringer.gooperator/vendor/google.golang.org/protobuf/internal/encoding/tag/tag.gooperator/vendor/google.golang.org/protobuf/internal/encoding/text/decode.gooperator/vendor/google.golang.org/protobuf/internal/filedesc/desc.gooperator/vendor/google.golang.org/protobuf/internal/filedesc/desc_init.gooperator/vendor/google.golang.org/protobuf/internal/filedesc/desc_lazy.gooperator/vendor/google.golang.org/protobuf/internal/filedesc/editions.gooperator/vendor/google.golang.org/protobuf/internal/genid/descriptor_gen.gooperator/vendor/google.golang.org/protobuf/internal/impl/codec_map.gooperator/vendor/google.golang.org/protobuf/internal/impl/decode.gooperator/vendor/google.golang.org/protobuf/internal/impl/validate.gooperator/vendor/google.golang.org/protobuf/internal/version/version.gooperator/vendor/google.golang.org/protobuf/proto/decode.gooperator/vendor/k8s.io/api/admission/v1/generated.protooperator/vendor/k8s.io/api/admission/v1/types.gooperator/vendor/k8s.io/api/admission/v1beta1/generated.protooperator/vendor/k8s.io/api/admission/v1beta1/types.gooperator/vendor/k8s.io/api/admissionregistration/v1/generated.protooperator/vendor/k8s.io/api/admissionregistration/v1/register.gooperator/vendor/k8s.io/api/admissionregistration/v1/types.gooperator/vendor/k8s.io/api/admissionregistration/v1/zz_generated.deepcopy.gooperator/vendor/k8s.io/api/admissionregistration/v1/zz_generated.model_name.gooperator/vendor/k8s.io/api/admissionregistration/v1/zz_generated.prerelease-lifecycle.gooperator/vendor/k8s.io/api/admissionregistration/v1alpha1/generated.protooperator/vendor/k8s.io/api/admissionregistration/v1alpha1/types.gooperator/vendor/k8s.io/api/admissionregistration/v1beta1/generated.protooperator/vendor/k8s.io/api/admissionregistration/v1beta1/types.gooperator/vendor/k8s.io/api/admissionregistration/v1beta1/zz_generated.prerelease-lifecycle.gooperator/vendor/k8s.io/api/apidiscovery/v2/generated.protooperator/vendor/k8s.io/api/apidiscovery/v2/types.gooperator/vendor/k8s.io/api/apidiscovery/v2beta1/generated.proto
💤 Files with no reviewable changes (41)
- operator/vendor/github.com/gogo/protobuf/proto/duration.go
- operator/vendor/github.com/emicklei/go-restful/v3/.travis.yml
- operator/vendor/github.com/gregjones/httpcache/README.md
- operator/vendor/github.com/gogo/protobuf/AUTHORS
- operator/vendor/github.com/gogo/protobuf/proto/duration_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/text.go
- operator/vendor/github.com/gogo/protobuf/proto/Makefile
- operator/vendor/github.com/gogo/protobuf/proto/table_marshal_gogo.go
- operator/vendor/github.com/prometheus/common/expfmt/fuzz.go
- operator/vendor/github.com/gogo/protobuf/proto/pointer_reflect.go
- operator/vendor/github.com/gogo/protobuf/proto/equal.go
- operator/vendor/github.com/gogo/protobuf/proto/wrappers.go
- operator/vendor/github.com/gogo/protobuf/proto/custom_gogo.go
- operator/vendor/github.com/gogo/protobuf/CONTRIBUTORS
- operator/vendor/github.com/gogo/protobuf/proto/pointer_reflect_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/encode_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/properties_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go
- operator/vendor/github.com/gogo/protobuf/proto/encode.go
- operator/vendor/github.com/gogo/protobuf/proto/wrappers_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/lib_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/discard.go
- operator/vendor/github.com/gogo/protobuf/proto/timestamp_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/pointer_unsafe_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/table_unmarshal_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/pointer_unsafe.go
- operator/vendor/github.com/gogo/protobuf/proto/table_merge.go
- operator/vendor/github.com/gogo/protobuf/proto/text_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/text_parser.go
- operator/vendor/github.com/gogo/protobuf/proto/properties.go
- operator/vendor/github.com/gogo/protobuf/proto/extensions_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/clone.go
- operator/vendor/github.com/gregjones/httpcache/.travis.yml
- operator/vendor/github.com/gogo/protobuf/proto/extensions.go
- operator/vendor/github.com/gogo/protobuf/proto/skip_gogo.go
- operator/vendor/github.com/gogo/protobuf/proto/decode.go
- operator/vendor/github.com/gogo/protobuf/proto/lib.go
- operator/vendor/github.com/gogo/protobuf/proto/deprecated.go
- operator/vendor/github.com/gogo/protobuf/sortkeys/sortkeys.go
- operator/vendor/github.com/gogo/protobuf/proto/timestamp.go
- operator/vendor/github.com/gogo/protobuf/proto/message_set.go
Summary
Code changes forced by the cross-minor jump
Defaulter[*T] / Validator[*T]. Dropped the now-redundant obj.(*T) assertions and runtime.Object parameter types.
Test plan
Notes
Checklist
git commit -s) per the DCO.