Skip to content

nv-redfish: Support WIWYNN non-standard response of chassis assembly#18

Merged
poroh merged 1 commit intoNVIDIA:mainfrom
poroh:wiwynn-chassis-assembly-support
Feb 17, 2026
Merged

nv-redfish: Support WIWYNN non-standard response of chassis assembly#18
poroh merged 1 commit intoNVIDIA:mainfrom
poroh:wiwynn-chassis-assembly-support

Conversation

@poroh
Copy link
Copy Markdown
Contributor

@poroh poroh commented Feb 14, 2026

Support of WIWYNN's non-standard response on Assembly resource in Chassis which doesn't contain required "@data.type" field.

@poroh poroh requested a review from yoks February 14, 2026 22:36
Comment thread redfish/src/patch_support/payload.rs Outdated
}
}

#[allow(dead_code)] // enabled by features
Copy link
Copy Markdown
Contributor

@yoks yoks Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other way to make it work without linter allow? If it enabled by features maybe annotate with set of features which enable it? Also make it a little bit clearer to see what features involved

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added feature-gating for patch functions as separate PR: #19 . This one in draft (will be merged on top of 19).

@poroh poroh force-pushed the wiwynn-chassis-assembly-support branch 2 times, most recently from 453ede5 to 8dee091 Compare February 15, 2026 19:04
@poroh poroh marked this pull request as draft February 15, 2026 19:10
Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
@poroh poroh force-pushed the wiwynn-chassis-assembly-support branch from 8dee091 to 0a2602d Compare February 15, 2026 21:03
@poroh poroh marked this pull request as ready for review February 15, 2026 21:04
@poroh poroh merged commit 4cd44fb into NVIDIA:main Feb 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants