fix: clippy enum_variant_names Self hints and rustdoc broken links#70
Merged
poroh merged 1 commit intoNVIDIA:mainfrom Apr 15, 2026
Merged
fix: clippy enum_variant_names Self hints and rustdoc broken links#70poroh merged 1 commit intoNVIDIA:mainfrom
enum_variant_names Self hints and rustdoc broken links#70poroh merged 1 commit intoNVIDIA:mainfrom
Conversation
- Replace explicit enum/struct self-references with `Self` in `Box<>`,
addressing clippy::use_self lint (Rust 1.87+):
- core: FilterExpr variants
- csdl-compiler: compiler::Error, ValidateError, annotation::Error,
generator::rust::Error, Stack, ModDef
- Fix rustdoc broken intra-doc links in entity_link module by using
fully qualified `crate::entity_link::EntityLink` paths in module-level
doc comments (bare names don't resolve from `//!` docs)
- Fix stale `MetricReportRef` references in telemetry_service docs,
renamed to `MetricReportLink`
Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
yoks
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace explicit enum/struct self-references with
SelfinBox<>, addressing clippy::use_self lint (Rust 1.87+):Fix rustdoc broken intra-doc links in entity_link module by using fully qualified
crate::entity_link::EntityLinkpaths in module-level doc comments (bare names don't resolve from//!docs)Fix stale
MetricReportRefreferences in telemetry_service docs, renamed toMetricReportLink