Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Jun 12, 2025

This change allows device IDs to the specified in the GetSpec API.
This simplifies cases where CDI specs are being generated for specific
devices by ID.

elezar added 2 commits June 12, 2025 16:23
This change allows device IDs to the specified in the GetSpec API.
This simplifies cases where CDI specs are being generated for specific
devices by ID.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar requested review from jgehrcke and klueska June 12, 2025 14:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15613494126

Details

  • 9 of 20 (45.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 33.619%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nvcdi/gds.go 0 1 0.0%
pkg/nvcdi/lib-csv.go 0 1 0.0%
pkg/nvcdi/lib-imex.go 0 1 0.0%
pkg/nvcdi/lib-nvml.go 0 1 0.0%
pkg/nvcdi/lib-wsl.go 0 1 0.0%
pkg/nvcdi/management.go 0 1 0.0%
pkg/nvcdi/mofed.go 0 1 0.0%
internal/modifier/cdi.go 0 2 0.0%
pkg/nvcdi/wrapper.go 9 11 81.82%
Totals Coverage Status
Change from base Build 15585515442: 0.07%
Covered Lines: 4279
Relevant Lines: 12728

💛 - Coveralls

@elezar elezar self-assigned this Jun 13, 2025
@elezar elezar merged commit cc78124 into NVIDIA:main Jun 13, 2025
16 checks passed
@elezar elezar deleted the add-device-ids-to-getspec branch June 13, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants